Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled resource kind PodDisruptionBudget and CRD for health status. #448

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

iamvikaskumar
Copy link
Contributor

@iamvikaskumar iamvikaskumar commented Jul 27, 2023

Changes Proposed

Added hdHealth status for PodDisruptionBudget and CRD.
Below is the criterion for healthy status :
For CRD : if both the conditions (Established and NamesAccepted) are true.
For PodDisruptionBudget : if condition DisruptionAllowed is true.

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue: Relates to Handle more resource kind health status #418
  • I have documented the changes made (if applicable)
  • I have covered the changes with unit tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.87%. Comparing base (64331ad) to head (9867084).
Report is 63 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #448   +/-   ##
=======================================
  Coverage   29.87%   29.87%           
=======================================
  Files          10       10           
  Lines        1339     1339           
=======================================
  Hits          400      400           
  Misses        900      900           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undera
Copy link
Collaborator

undera commented Jul 28, 2023

Looks good. gocyclo complaints can be addressed in a separate PR.

@undera undera merged commit 0b35433 into komodorio:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants