Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated Storybook notation from CSF2 to CSF3 #487

Merged

Conversation

kamegoro
Copy link
Contributor

@kamegoro kamegoro commented Nov 1, 2023

Changes Proposed

Basically, no component changes were made and the migration was done using Storybook's migration commands.

The parts that were updated manually are as follows

  • Deletion of unnecessary modules loaded when the migration command was executed
  • Type storage to resolve type errors

Details are left in the issue

#486

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue:
  • I have documented the changes made (if applicable)
  • [ ] I have covered the changes with unit tests
    • Not supported as it is an unaffected area.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f465c83) 29.85% compared to head (2a55f4c) 29.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   29.85%   29.85%           
=======================================
  Files          10       10           
  Lines        1323     1323           
=======================================
  Hits          395      395           
  Misses        887      887           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undera undera merged commit de1915e into komodorio:main Nov 1, 2023
4 checks passed
@undera
Copy link
Collaborator

undera commented Nov 1, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants