Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update helm charts for helm-dashboard #490

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

warjiang
Copy link
Contributor

@warjiang warjiang commented Nov 7, 2023

  1. fix imagePullSecrets bug in deployment.yaml
  2. add global config
  3. optimize image field with global registry config

Changes Proposed

this pr is for charts of helm-dashboard

  1. fix imagePullSecrets bug in deployment.yaml
    img_v2_98d59d03-f62c-43e2-86f3-33c51ca45dfg
    if use old deployment.yaml it will reported that e expect map but get string

  2. add global config
    busybox image is hard code in the charts, so i propose to use global.imageRegistry to unify render of image. same with imagePullSecrets

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue:
  • I have documented the changes made (if applicable)
  • I have covered the changes with unit tests

1. fix `imagePullSecrets` bug in deployment.yaml
2. add `global` config
3. optimize image field with global registry config
@undera
Copy link
Collaborator

undera commented Nov 7, 2023

Thank you!

@undera undera merged commit d78e0c5 into komodorio:main Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants