Build failed at 1.2.0 with Rust 1.80.0

[brsvh]

rust-lang/rust#99969 added some FromIterator impls for Box<str> to the standard library, version 1.2.0 failed when build on Rust 1.80.0.

  --> /home/bsc/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.23/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

We need to update its dependencied time from 0.3.23 to 0.3.36, IMO, may be a new release is a straightforward fix.

I found it when update NixOS/Nixpkgs, and mentioned here

[konradsz]

Hello,
thanks for reaching out! I checked the compilation using cargo +1.80.0 check and it finishes successfully. CI is currently running on 1.80.1 and it compiles as well. Where can I find complete log of a failing compilation?

[tukanoidd]

Have the same issue, here's my log:

Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/pldygzwd8b9fsp29ic5g1qcxcd2i35bz-source
source root is source
Executing cargoSetupPostUnpackHook
unpacking source archive /nix/store/8b5yjgzp8mrh2yxrp3bqcywwkh0cky5c-igrep-1.2.0-vendor.tar.gz
Finished cargoSetupPostUnpackHook
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Executing cargoSetupPostPatchHook
Validating consistency between /build/source/Cargo.lock and /build/igrep-1.2.0-vendor.tar.gz/Cargo.lock
Finished cargoSetupPostPatchHook
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Executing cargoBuildHook
++ env CC_X86_64_UNKNOWN_LINUX_GNU=/nix/store/lbk30k56awz9vz9qpid93fkjns0xwlhd-gcc-wrapper-13.3.0/bin/cc CXX_X86_64_UNKNOWN_LINUX_GNU=/nix/store/lbk30k56awz9vz9qpid93fkjns0xwlhd-gcc-wrapper-13.3.0/bin/c++ CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_LINKER=/nix/store/lbk30k56awz9vz9qpid93fkjns0xwlhd-gcc-wrapper-13.3.0/bin/cc CC_X86_64_UNKNOWN_LINUX_GNU=/nix/store/lbk30k56awz9vz9qpid93fkjns0xwlhd-gcc-wrapper-13.3.0/bin/cc CXX_X86_64_UNKNOWN_LINUX_GNU=/nix/store/lbk30k56awz9vz9qpid93fkjns0xwlhd-gcc-wrapper-13.3.0/bin/c++ CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_LINKER=/nix/store/lbk30k56awz9vz9qpid93fkjns0xwlhd-gcc-wrapper-13.3.0/bin/cc CARGO_BUILD_TARGET=x86_64-unknown-linux-gnu HOST_CC=/nix/store/lbk30k56awz9vz9qpid93fkjns0xwlhd-gcc-wrapper-13.3.0/bin/cc HOST_CXX=/nix/store/lbk30k56awz9vz9qpid93fkjns0xwlhd-gcc-wrapper-13.3.0/bin/c++ cargo build -j 20 --target x86_64-unknown-linux-gnu --offline --profile release
warning: `/build/.cargo/config` is deprecated in favor of `config.toml`
note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
warning: `/build/.cargo/config` is deprecated in favor of `config.toml`
note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
   Compiling memchr v2.5.0
   Compiling libc v0.2.147
   Compiling cfg-if v1.0.0
   Compiling proc-macro2 v1.0.66
   Compiling unicode-ident v1.0.11
   Compiling autocfg v1.1.0
   Compiling log v0.4.19
   Compiling regex-syntax v0.7.4
   Compiling serde v1.0.173
   Compiling version_check v0.9.4
   Compiling once_cell v1.18.0
   Compiling syn v1.0.109
   Compiling serde_derive v1.0.173
   Compiling signal-hook v0.3.17
   Compiling bitflags v1.3.2
   Compiling itoa v1.0.9
   Compiling parking_lot_core v0.9.8
   Compiling pkg-config v0.3.27
   Compiling scopeguard v1.2.0
   Compiling fnv v1.0.7
   Compiling smallvec v1.11.0
   Compiling same-file v1.0.6
   Compiling cc v1.0.79
   Compiling serde_json v1.0.103
   Compiling encoding_rs v0.8.32
   Compiling rustversion v1.0.14
   Compiling crc32fast v1.3.2
   Compiling termcolor v1.2.0
   Compiling lazy_static v1.4.0
   Compiling heck v0.4.1
   Compiling hashbrown v0.12.3
   Compiling ryu v1.0.15
   Compiling thread_local v1.1.7
   Compiling regex-syntax v0.6.29
   Compiling time-core v0.1.1
   Compiling bytecount v0.6.3
   Compiling proc-macro-error-attr v1.0.4
   Compiling proc-macro-error v1.0.4
   Compiling adler v1.0.2
   Compiling safemem v0.3.3
   Compiling thiserror v1.0.43
   Compiling miniz_oxide v0.7.1
   Compiling line-wrap v0.1.1
   Compiling lock_api v0.4.10
   Compiling indexmap v1.9.3
   Compiling time v0.3.23
   Compiling walkdir v2.3.3
   Compiling base64 v0.21.2
   Compiling os_str_bytes v6.5.1
   Compiling base64 v0.20.0
   Compiling anyhow v1.0.72
   Compiling signal-hook-registry v1.4.1
   Compiling mio v0.8.8
   Compiling aho-corasick v1.0.2
error[E0282]: type annotations needed for `Box<_>`
  --> /build/igrep-1.2.0-vendor.tar.gz/time/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

   Compiling quote v1.0.31
   Compiling grep-matcher v0.1.6
   Compiling syn v2.0.26
   Compiling signal-hook-mio v0.2.3
   Compiling memmap2 v0.5.10
   Compiling parking_lot v0.12.1
   Compiling quick-xml v0.29.0
   Compiling aho-corasick v0.7.20
   Compiling linked-hash-map v0.5.6
   Compiling crossterm v0.26.1
   Compiling yaml-rust v0.4.5
For more information about this error, try `rustc --explain E0282`.
error: could not compile `time` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Although your comment makes me think it could be something on nixpkgs side after all?

[brsvh]

Hello,
thanks for reaching out! I checked the compilation using cargo +1.80.0 check and it finishes successfully. CI is currently running on 1.80.1 and it compiles as well. Where can I find complete log of a failing compilation?

The main branch is no problems, only the tag 1.2.0 is broken.

Actually, we just need the syntect in 1.2.0 update to a version which will use time 0.3.36.

[konradsz]

Oh right, 1.2.0 is quite old at this point and I don't really want to patch it. I will release 1.3.0 this week!

[konradsz]

1.3.0 released!