Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency on @types/react-reconciler #733

Closed
Methuselah96 opened this issue Feb 16, 2023 · 2 comments · Fixed by #734
Closed

Missing dependency on @types/react-reconciler #733

Methuselah96 opened this issue Feb 16, 2023 · 2 comments · Fixed by #734

Comments

@Methuselah96
Copy link
Contributor

The declaration files depend on @types/react-reconciler and therefore the package should have a dependency on it. When using a strict package manager like Yarn PnP or pnpm, the lack of a dependency causes type errors:

ERROR in ../../.yarn/__virtual__/react-konva-virtual-6ed89b947b/0/cache/react-konva-npm-18.2.4-51a1623011-b741a877dd.zip/node_modules/react-konva/ReactKonvaCore.d.ts:3:34
TS7016: Could not find a declaration file for module 'react-reconciler'. '/home/runner/work/org/repo/.yarn/__virtual__/react-reconciler-virtual-e7fbc7a2c3/0/cache/react-reconciler-npm-0.29.0-57f1460fdd-730db9cf45.zip/node_modules/react-reconciler/index.js' implicitly has an 'any' type.
  If the 'react-reconciler' package actually exposes this module, consider sending a pull request to amend 'https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-reconciler'
    1 | // special file for minimal import
    2 | import * as React from 'react';
  > 3 | import * as ReactReconciler from 'react-reconciler'
      |                                  ^^^^^^^^^^^^^^^^^^
    4 | import Konva from 'konva';
    5 |
    6 | export interface KonvaNodeEvents {
@lavrton
Copy link
Member

lavrton commented Feb 20, 2023

Please try now with the last version.

@Methuselah96
Copy link
Contributor Author

That worked, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants