Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Idenfify's largeThreshold configurable, or raise it to 250 #460

Closed
Galarzaa90 opened this issue Dec 17, 2021 · 3 comments
Closed

Make Idenfify's largeThreshold configurable, or raise it to 250 #460

Galarzaa90 opened this issue Dec 17, 2021 · 3 comments

Comments

@Galarzaa90
Copy link
Contributor

Galarzaa90 commented Dec 17, 2021

It seems like by default, DefaultGateway is being used, which has largeThreshold set to 50:

internal val GatewayConfiguration.identify
get() = Identify(
token,
IdentifyProperties(os, name, name),
false.optional(),
50.optionalInt(),
shard.optional(),
presence,
intents
)

I couldn't find a way to change this using the KordBuilder.

Increasing this could aid larger bots in reducing the amount of guilds that need to have their members requested.

I don't know if there would be a drawback in increasing this to 250 by default. But if there is, exposing it so it can be configured would be good.

@HopeBaron
Copy link
Member

Should be able to specify threshold from gateway configuration now

@Galarzaa90
Copy link
Contributor Author

How can this be set using KordBuilder? Since I'm using KordEx, this is the only thing I have to configure Kord (as far as I know)

I see that this is defined from GatewayConfigurationBuilder in the start extension function of Gateway.

@HopeBaron
Copy link
Member

it's 250 by default as far as the builder implies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants