Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing maintainer scripts does not output logs #69

Open
ltabis opened this issue Jan 21, 2023 · 4 comments
Open

Missing maintainer scripts does not output logs #69

ltabis opened this issue Jan 21, 2023 · 4 comments

Comments

@ltabis
Copy link

ltabis commented Jan 21, 2023

I add a bit of trouble lately creating debian packages using cargo deb: while I specified in my cargo manifest the maintainer-scripts field, none of my scripts where being picked-up by the program. In fact: the path I used was erroneous. Unfortunately, cargo deb did not provide any useful log/message about the matter.

Could it be interesting to display a warning when no files are found for maintainer scripts if the maintainer-scripts field is present in the cargo manifest ?

If you think it could be useful, I would be happy to make a pull request.

@ltabis ltabis changed the title Missing maintainer scripts Missing maintainer scripts does not output logs Jan 21, 2023
@kornelski
Copy link
Owner

Yes, it'd be useful. I think it could even fail the build if they're missing. But this may need to be checked after the build, so that build.rs has a chance to generate them.

@ltabis
Copy link
Author

ltabis commented Jan 22, 2023

But this may need to be checked after the build

Alright, I will take a look then !

@ximon18
Copy link
Contributor

ximon18 commented Jan 23, 2023

Related issue? #30

@ltabis
Copy link
Author

ltabis commented Jan 23, 2023

Related issue? #30

More or less, this issue is related to eventual missing maintainer scripts, #30 is for missing assets. Emitting a warning for missing assets also seems like a good idea to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants