Add source_pr_number input
#434
Conversation
Fixes korthout#433 Signed-off-by: Chance Zibolski <[email protected]>
Currently the inputs are ordered alphabetically (I know underscores aren't actually part of the alphabet). So, let's maintain this ordering.
Note that this is not specific to the workflow_dispatch event type. It should also work for other event types.
There was a problem hiding this comment.
Thanks @chancez for this great contribution!
I finally had some time to look at open pull requests here. Sorry for the long wait 🙇
I really like the feature and will gladly support it. There's just one question remaining for me: why should this only be supported for workflow_dispatch?
EDIT: I've taken the liberty to remove this restriction already, but if you see a reason for this we can take away these commits again. Let me know what you think.
src/backport.ts
Outdated
| if ( | ||
| this.config.source_pr_number !== undefined && | ||
| this.github.getEventName() !== "workflow_dispatch" | ||
| ) { | ||
| throw new Error( | ||
| "source_pr_number can only be specified for workflow_dispatch events!", |
There was a problem hiding this comment.
❓ Why only for this event type? Do you see a specific reason to not allow this for other event types?
There was a problem hiding this comment.
I think this is fine. I believe I was just being cautious.
As far as I can see, there is no reason to limit the source_pr_number input only to usage with workflow_dispatch events. Other workflows may also benefit from this input if they want to specify the pull request.
I don't see any big reason, I think I just was being cautious, because I think I remember seeing the GHA already checking the event type in another case, so I think I just copied it. I can't remember exactly though. |
korthout
changed the title
source_pr_number input
|
Released in |
Fixes #433
I've tested this in the repo I'm using this with and its been working well for manually triggering on some PRs that we merged prior to introducing the GHA.