Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dependencies in Cargo.toml gated with cfg! #72

Closed
koute opened this issue Feb 24, 2018 · 6 comments
Closed

Support dependencies in Cargo.toml gated with cfg! #72

koute opened this issue Feb 24, 2018 · 6 comments

Comments

@koute
Copy link
Owner

koute commented Feb 24, 2018

Related: koute/stdweb#135

@kuviman
Copy link
Contributor

kuviman commented Mar 3, 2018

Hello, it looks like there is also an issue if the dependency is specified multiple times for different targets, like:

[target.wasm32-unknown-emscripten.dependencies]
stdweb = "*"
[target.asmjs-unknown-emscripten.dependencies]
stdweb = "*"

This way, stdweb's JavaScript is only prepended to asmjs output

@koute
Copy link
Owner Author

koute commented Mar 5, 2018

@kuviman Thanks for the report; I've fixed in on the newest master. I'll try to release a new cargo-web with this fix today.

@svenstaro
Copy link

Still doesn't seem to work and I can't find the relevant commit. What's the status on this?

@koute
Copy link
Owner Author

koute commented May 17, 2018

@svenstaro By "I've fixed" I meant the issue reported by kuviman where specifing the dependency for multiple targets was broken, which is an orthogonal issue to cfg support. (Although it was reported here, so I've also replied here.)

@kuviman
Copy link
Contributor

kuviman commented Apr 18, 2019

This one has been implemented, right?

Looks like its working for me

@koute
Copy link
Owner Author

koute commented Apr 18, 2019

Yes it is! (:

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants