Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long diff #34

Closed
eGavr opened this issue Sep 10, 2014 · 6 comments
Closed

Long diff #34

eGavr opened this issue Sep 10, 2014 · 6 comments

Comments

@eGavr
Copy link

eGavr commented Sep 10, 2014

If there are so many diffs between two texts, this loop works so slow that the operating system thinks that it fails, so after a while stops it at all.

It is a variant to show not all diffs, but only a part of them.
For example, with the help of some option we could set the maximum amount of diffs.

@kpdecker
Copy link
Owner

What environment is this running in? How long of a duration are we talking about?

Can you provide an example script that demonstrates the failure? Adding a parameter is not difficult but tuning such a parameter is extremely difficult to do so I'm not sure of the value of such a parameter.

Rather profiling and/or making the operations async seem to be a better option for throwing truely massive data at the system.

@kpdecker
Copy link
Owner

#27 improves the runtime loop dramatically. I'm also going to investigate async chunking of the algorithm to make large datasets play nicely with concurrent tasks.

@eGavr
Copy link
Author

eGavr commented Nov 29, 2014

I have two really long HTMLs and they have more then 5000 diffs. In this case it fails.

@kpdecker
Copy link
Owner

You're not giving me very much to work on, but large diffs are going to be slow, even with #27. For such cases you should use the async mode that is about to be released.

@eGavr
Copy link
Author

eGavr commented Nov 30, 2014

It is a good news! I hope that async algorithm will solve this problem!

@jononomo
Copy link

Any docs on this async mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants