-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long diff #34
Comments
What environment is this running in? How long of a duration are we talking about? Can you provide an example script that demonstrates the failure? Adding a parameter is not difficult but tuning such a parameter is extremely difficult to do so I'm not sure of the value of such a parameter. Rather profiling and/or making the operations async seem to be a better option for throwing truely massive data at the system. |
#27 improves the runtime loop dramatically. I'm also going to investigate async chunking of the algorithm to make large datasets play nicely with concurrent tasks. |
I have two really long HTMLs and they have more then 5000 diffs. In this case it fails. |
You're not giving me very much to work on, but large diffs are going to be slow, even with #27. For such cases you should use the async mode that is about to be released. |
It is a good news! I hope that async algorithm will solve this problem! |
Any docs on this async mode? |
If there are so many diffs between two texts, this loop works so slow that the operating system thinks that it fails, so after a while stops it at all.
It is a variant to show not all diffs, but only a part of them.
For example, with the help of some option we could set the maximum amount of diffs.
The text was updated successfully, but these errors were encountered: