Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff headers give error #76

Closed
piranna opened this issue Sep 22, 2015 · 4 comments
Closed

diff headers give error #76

piranna opened this issue Sep 22, 2015 · 4 comments

Comments

@piranna
Copy link
Contributor

piranna commented Sep 22, 2015

When patching with https://github.com/maximeh/buildroot/blob/0400322f2d4e28faa98e31815921f54106aeb2e6/package/openssl/openssl-004-musl-termios.patch, it give the next error:

/home/piranna/Proyectos/NodeOS/node_modules/diff/lib/patch/parse.js:44
        throw new Error('Unknown line ' + (i + 1) + ' ' + JSON.stringify(diffs
              ^
Error: Unknown line 1 "http://rt.openssl.org/Ticket/Display.html?id=3123"
    at parseIndex (/home/piranna/Proyectos/NodeOS/node_modules/diff/lib/patch/parse.js:44:15)
    at Object.parsePatch (/home/piranna/Proyectos/NodeOS/node_modules/diff/lib/patch/parse.js:120:5)
    at applyPatch (/home/piranna/Proyectos/NodeOS/node_modules/diff/lib/patch/apply.js:13:22)
    at /home/piranna/Proyectos/NodeOS/node_modules/nodeos-barebones/scripts/preinstall:56:30
    at fs.js:334:14
    at FSReqWrap.oncomplete (fs.js:95:15)

Seems that after adding support for multiple indexes this got broken and now the first comment lines of the patch don't get ignored.

@piranna
Copy link
Contributor Author

piranna commented Sep 22, 2015

I've checked it and the error was introduced on version 2.0.0

@kpdecker
Copy link
Owner

I've relaxed the parser to ignore unexpected lines unless in strict mode.

@kpdecker
Copy link
Owner

Released in 2.1.2

@piranna
Copy link
Contributor Author

piranna commented Sep 24, 2015

Cool, thank you! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants