From 3ad4307054bb5dfca6f463c95521bd3e935eebc4 Mon Sep 17 00:00:00 2001 From: Martijn Dekker Date: Thu, 28 Jan 2021 04:01:49 +0000 Subject: [PATCH] name.c: fix possible crash in attstore() From OpenSUSE: https://build.opensuse.org/package/view_file/shells/ksh/ksh93-env.dif (the init.c fix there is already done differently in 3654ee73) src/cmd/ksh93/sh/name.c: attstore(): - Check nv_mapchar() returns a non-null pointer before using it. --- src/cmd/ksh93/sh/name.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/ksh93/sh/name.c b/src/cmd/ksh93/sh/name.c index 5866ea3393db..1b77537003b4 100644 --- a/src/cmd/ksh93/sh/name.c +++ b/src/cmd/ksh93/sh/name.c @@ -2113,7 +2113,7 @@ static void attstore(register Namval_t *np, void *data) if((flag&(NV_UTOL|NV_LTOU|NV_INTEGER)) == (NV_UTOL|NV_LTOU)) { data = (void*)nv_mapchar(np,0); - if(strcmp(data,e_tolower) && strcmp(data,e_toupper)) + if(data && strcmp(data,e_tolower) && strcmp(data,e_toupper)) return; } flag &= (NV_RDONLY|NV_UTOL|NV_LTOU|NV_RJUST|NV_LJUST|NV_ZFILL|NV_INTEGER);