Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question/Feature request: Monitoring/Alerting for Flows/Outputs #1748

Open
sebastiangaiser opened this issue May 27, 2024 · 7 comments
Open
Labels
help wanted Extra attention is needed pinned
Milestone

Comments

@sebastiangaiser
Copy link
Contributor

sebastiangaiser commented May 27, 2024

Is your feature request related to a problem? Please describe.
Hey, I was thinking about how to monitor whether a Flow/Output resource is having problems or is working fine.

Describe the solution you'd like
I would like to build a kind of alerting (via PrometheusRule) indicating the status of a Flow/Output. The alerts should be sent to each team/namespace individually. For me the question is how is it supposed to work.
Monitoring and Alerting docs are not tackling this, yet.

Describe alternatives you've considered
Other tools like Flux achieved this by using kube-state-metrics (ksm). Ksm aggregates the status object and builds a Prometheus metric on top of that.

Additional context
Flux documentation: https://fluxcd.io/flux/monitoring/custom-metrics/
Flux example repository: https://github.com/fluxcd/flux2-monitoring-example

@sebastiangaiser
Copy link
Contributor Author

@pepov sorry to ping you but could you please mind have a look :D

@pepov
Copy link
Member

pepov commented Jun 18, 2024

Hey, sorry for the late response! Using kube-state-metrics could be a good idea since the flow/output resources already have a status with an active flag and problem count that could be used to detect issues. What would an integration with ksm mean for the logging operator? Would that be just documentation or would that imply some automation in the operator?

@sebastiangaiser
Copy link
Contributor Author

Hey, thank you for your response. For me an idea would be to include the ksm as optional subchart and insert a config via Helm values.

@pepov
Copy link
Member

pepov commented Jun 18, 2024

@sebastiangaiser in case of the prometheus operator that is a reasonable thing to have but for the logging operator this would be an overkill in my opinion. Even in case of flux the example is a demonstration of how to configure ksm through the kube-prometheus-stack to have monitoring for custom resources. I would prefer this type of support in our case as well.

@sebastiangaiser
Copy link
Contributor Author

The flux example with the kube-prometheus-stack uses the ksm chart itself as a subchart.
For me personally, I don't like to mix the kube-prometheus-stack with any not related CRs monitoring. So for Flux, I deployed the ksm chart on my own. The downside of that is that you end up with multiple ksm deployments but this gives me independents of my logging-stack from my monitoring-stack. But of course, documenting it works out, too.

@pepov pepov added the help wanted Extra attention is needed label Jun 18, 2024
@stale stale bot added the wontfix This will not be worked on label Aug 17, 2024
@sebastiangaiser
Copy link
Contributor Author

Not stale

@stale stale bot removed the wontfix This will not be worked on label Aug 17, 2024
@stale stale bot added the wontfix This will not be worked on label Oct 16, 2024
@sebastiangaiser
Copy link
Contributor Author

@pepov can you please pin this issue

@stale stale bot removed the wontfix This will not be worked on label Oct 17, 2024
@pepov pepov pinned this issue Oct 24, 2024
@pepov pepov unpinned this issue Oct 24, 2024
@pepov pepov added the pinned label Oct 24, 2024
@kube-logging kube-logging deleted a comment from stale bot Nov 27, 2024
@kube-logging kube-logging deleted a comment from stale bot Nov 27, 2024
@csatib02 csatib02 added this to the Misc/Other milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed pinned
Projects
None yet
Development

No branches or pull requests

3 participants