fix(ci): coverage report generation for k8s_env tests #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DelusionalOptimist |
|
might fix #845 |
Signed-off-by: tesla59 <[email protected]>
tesla59
force-pushed
the
tesla/fix-coverage
branch
from
a844c46
to
caa0945
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #1758
Does this PR introduce a breaking change?
No, it changes Ci step
If the changes in this PR are manually verified, list down the scenarios covered::
N/A
Additional information for reviewer? :
The main purpose of gover is to concatenate multiple cover profiles into a single file. We dont need to do this as ginkgo already stored the cover profile in a single file (by default coverprofile.out).
The PR adds a flag in ginkgo test command to generate test profile for every package in the
github.com/kubearmor/KubeArmor/tests. The reason to use full path is a bug in ginkgo when using relative path. It is supposedly fixed but using the relative path didnt work in our case (ref: onsi/ginkgo#1161 (comment))Checklist:
<type>(<scope>): <subject>