Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Tekton version 0.14.0 #216

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Jul 3, 2020

Tekton has just released version 0.14.0 which implements support for finally:


  • implementing pipeline level finally (tektoncd/pipelines#2661)
    Users can now specify Tasks within a Pipeline that will always execute, even if Tasks fail, via the new finally clause

  • adding finally type (without implementation) at the pipeline level (tektoncd/pipelines#2650)
    Introducing a new clause under pipeline named finally where users can specify a list of tasks that will always execute, even if pipeline tasks fail. Adding a new type and its validation here, stay tuned for this functionality. Without implementing the functionality, a list of tasks under finally are validated but not executed at all.


This PR proposes to upgrade our supported/required Tekton version from 0.13.0 to 0.14.0.

Marking this PR as [WIP] while I upgrade my Tekton cluster and run the full set of E2E tests to make sure there are no issues.

/cc @Tomcli @animeshsingh

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Jul 4, 2020
@ckadner ckadner changed the title [WIP] Upgrade to Tekton version 0.14.0 Upgrade to Tekton version 0.14.0 Jul 6, 2020
@ckadner
Copy link
Member Author

ckadner commented Jul 6, 2020

I ran the end-to-end tests successfully for the Tekton 0.14.0 release.

The tkn pipelinerun logs command does not include the log out for the finally task(s) so I updated the "golden" exit_handler.log

sdk/FEATURES.md Outdated Show resolved Hide resolved
@Tomcli
Copy link
Member

Tomcli commented Jul 7, 2020

/lgtm

Copy link
Collaborator

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a59f04d into kubeflow:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants