-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Github Issue summarization codelab #871
Comments
Issue-Label Bot is automatically applying the label Links: app homepage, dashboard and code for this bot. |
/assign @texasmichelle please would you take a look at this issue and assign it to someone else if appropriate. |
/cc @texasmichelle |
@amygdala Do you know who owns this codelab? |
Unfortunately, it no longer has an owner amongst people who work on KF. (I'm the owner of the one in the 'pipelines' subdir, but not this one). @velascoluis was just testing it and said it didn't work properly. Luis, could you add the details of how it broke, to this bug? Was it ksonnet-related? We may need to just deprecate it for now, and possibly move the pipelines subdir one to under the 'pipelines' dir at the top level. |
Apparently Drew is working on a related qwiklabs replacement -- they pulled the qwiklabs version of this. (for googlers: https://buganizer.corp.google.com/issues/146655130) |
We replaced the qwiklab with the current end-to-end with digit classification and did not update the github summarization code. |
Should we just deprecate this codelab then? |
Potentially? It's pretty old at this ponit and seemed to serve the same purpose as https://www.kubeflow.org/docs/gke/gcp-e2e/ At cursory glance, only major differences were use-case and seldon core for serving vs tf serving. |
Hi, following step by step the issues I found are related to ksonnet. |
For now we're in the process of 'hiding' this codelab from the codelab index, and have also marked the text 'deprecated' for those who had the link bookmarked. For the record, here's Luis' notes when trying to run it:
IMHO this all should be migrated to kustomize and TFServing like in the prior example. TL;DR: This example seems pretty old and should be adapted. Does it makes sense to migrate to something like this? -> https://screenshot.googleplex.com/wDUr2DBFf38.png " |
The codelab has been 'deprecated' for now (& hidden in the index), but let's leave this open as a reminder to decide whether to update it or phase it out if we get more bandwidth. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is still referencing ksonnet:
https://codelabs.developers.google.com/codelabs/cloud-kubeflow-e2e-gis/index.html#5
The text was updated successfully, but these errors were encountered: