Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Add custom kubefed metrics and expose them on a prometheus friendly format #1194

Closed
hectorj2f opened this issue Feb 24, 2020 · 6 comments
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@hectorj2f
Copy link
Contributor

What would you like to be added:

I'd like to add custom metrics about kubefed that could be expose in a prometheus friendly basis analogously as other controller does in the Kubernetes ecosystem.

Why is this needed:

My intention would be to add custom metrics and a baseline that would enable to easily expose more metrics in the future.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 24, 2020
@irajdeep
Copy link

@hectorj2f We recently started using kubefed. So as an exercise to get familiar with the codebase, I can work on this, if no one else is currently working on it.

@hectorj2f
Copy link
Contributor Author

@irajdeep I already have a PR in the pipeline so I might create very soon. However I am willing to see if we can all benefit from your metrics as well.

@irajdeep
Copy link

@hectorj2f one of the metrics I had in mind related to how many objects kubefed failed to federate. If you haven't already implemented this metric, I can look into it.

@hectorj2f
Copy link
Contributor Author

@irajdeep look at #1196 :)

@irajdeep
Copy link

@hectorj2f nice. So I think I can wait for your PR to be merged to work on top of it to expose metrics related to objects which couldn't be federated

@hectorj2f
Copy link
Contributor Author

I am closing the issue, we added some custom metrics now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants