Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy the code from cli-experimental to cli-utils #1

Merged
merged 33 commits into from
Jul 31, 2019
Merged

copy the code from cli-experimental to cli-utils #1

merged 33 commits into from
Jul 31, 2019

Conversation

Liujingfang1
Copy link
Contributor

@Liujingfang1 Liujingfang1 commented Jul 31, 2019 •
edited
Loading

Keep the git history of cli-experimental

The last commit is to change the import path from cli-experimental to cli-utils

nikhita and others added 30 commits July 31, 2019 14:55
@nikhita @Liujingfang1
Update template files to include repo-specific info
c96821b
@pwittrock @Liujingfang1
Add .gitignore
07cd093
@pwittrock @Liujingfang1
Add travis checks
bb2e42f
@pwittrock @Liujingfang1
update CONTRIBUTING.md
e905a96
@pwittrock @Liujingfang1
Add scaffolding for apply commands
25ac98a 
- DependencyInjection wire
  - k8s deps
  - git deps
- apply and status libraries
- apply and status commands
- go modules
@pwittrock @Liujingfang1
Add support for dynamic commands published by CRDs
38e1577
@pwittrock @Liujingfang1
API for apply.yaml
2aa93f9
@barney-s @Liujingfang1
Adding dynamic-client interface
dd28dd9
@barney-s @Liujingfang1
refactor to reduce code duplication
add842f
@barney-s @Liujingfang1
Add mergepatch support and Apply() api
204b3e0
@barney-s @Liujingfang1
Adding tests and apply
8959f78 
- Adding tests
- Add ClientSideApply Support
- Update the client api to make options a pointer.
@Liujingfang1
add approvers
d3445dc
@Liujingfang1
first version of apply/prune/delete
68698ef
@Liujingfang1
address comments and add tests for pruning
f3ca02a
@Liujingfang1
split wirecli into each command wiring
5583826
@Liujingfang1
add Cmd to pkg
59cc078
@Liujingfang1
address comments
26b23e9
@Liujingfang1
implement RawConfigFileProvider
c98b06a
@Liujingfang1
add InitializeFakeCmd and use it in test
9015930
@Liujingfang1
address comments
bdb6f3c
@SataQiu @Liujingfang1
improve Makefile
3021f2f
@barney-s @Liujingfang1
Adding status command
26d681d
@barney-s @Liujingfang1
Refactoring Status code
8a721dc 
1. Adding conditions array as return value
2. Adding documentation
3. Adding more tests
@barney-s @Liujingfang1
1. Fix Succeeded typo
781841b 
2. Fix go generate failure
@barney-s @Liujingfang1
Fix cmd/status test error. We still need to fix the issue with resour…
e2bf215 
…ce ordering for this test to pass consistently
@Liujingfang1
update kustomize to 2.1.0 and fix the resource ordering issue
acf35fb
@Liujingfang1
add support for declarative deletion
a9fab7c
@Liujingfang1
add comments
fdb1117
@Liujingfang1
update prune to accept of slice of unstrucured
faad176
@Liujingfang1
add travis ci
452b744
@k8s-ci-robot
Copy link
Contributor

Welcome @Liujingfang1!

It looks like this is your first PR to kubernetes-sigs/cli-utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cli-utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from pwittrock and seans3 July 31, 2019 22:01
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 31, 2019
@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are not members of the kubernetes-sigs org.

  • barney-s
    • OWNERS

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 31, 2019
@Liujingfang1
Copy link
Contributor Author

@barney-s

@seans3
Copy link
Contributor

seans3 commented Jul 31, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Liujingfang1, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@Liujingfang1 Liujingfang1 removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit f4d3f70 into kubernetes-sigs:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwittrock pwittrock Awaiting requested review from pwittrock

@seans3 seans3 Awaiting requested review from seans3

Assignees

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Liujingfang1 @k8s-ci-robot @seans3 @nikhita @pwittrock @barney-s @SataQiu