🐛 don't override global log in builder #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change kubernetes-sigs@598978c#diff-e77b9468ab935d5ea4d5cdae3b994114bada17df0001570e4b1436419afd50ccR312 introduced a bug by overriding `log` with the log created by a builder, resulting in all logs produced by `controller-runtime` having `controller`, `controllerGroup` and `controllerKind` set to the last created controller.
k8s-ci-robot
added
cncf-cla: yes
alvaroaleman
changed the title
alvaroaleman
approved these changes
May 19, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Any plans to release a bugfix release of the v0.12 release branch? This is currently messing up our logs. |
|
+1 would be nice to have a v0.12.2 release. |
alvaroaleman
added a commit
to alvaroaleman/hypershift
that referenced
this pull request
Jun 24, 2022
4 tasks
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/hypershift
that referenced
this pull request
Jun 24, 2022
reachjainrahul
added a commit
to antrea-io/nephe
that referenced
this pull request
Aug 24, 2022
controller runtime v0.12.1 had issues in which, controller logging format was overwritten with last caller Name/Value. Please refer to PR kubernetes-sigs/controller-runtime#1911 Signed-off-by: Rahul Jain <[email protected]>
reachjainrahul
added a commit
to antrea-io/nephe
that referenced
this pull request
Aug 24, 2022
controller runtime v0.12.1 had issues in which, controller logging format was overwritten with last caller Name/Value. Please refer to PR kubernetes-sigs/controller-runtime#1911 Signed-off-by: Rahul Jain <[email protected]>
reachjainrahul
added a commit
to antrea-io/nephe
that referenced
this pull request
Aug 24, 2022
controller runtime v0.12.1 had issues in which, controller logging format was overwritten with last caller Name/Value. Please refer to PR kubernetes-sigs/controller-runtime#1911 Signed-off-by: Rahul Jain <[email protected]>
caboteria
added a commit
to epic-gateway/resource-model
that referenced
this pull request
Sep 7, 2023
kubernetes-sigs/controller-runtime#1911 This was causing all controllers to log from the slice controller logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1907
/assign alvaroaleman