Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠ Bump Kubernetes version to 1.14 #376

Merged
merged 2 commits into from
May 15, 2019
Merged

⚠ Bump Kubernetes version to 1.14 #376

merged 2 commits into from
May 15, 2019

Conversation

adracus
Copy link
Contributor

@adracus adracus commented Mar 27, 2019 •
edited
Loading

Bump versions of dependencies to Kubernetes 1.14.
@DirectXMan12 I guess you could base #366 on this to both speed up your development + keep the code review volume for your PR small.

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 27, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 27, 2019
@adracus
Copy link
Contributor Author

adracus commented Mar 27, 2019

/assign @DirectXMan12

@adracus adracus changed the title ⚠ Bump Kubernetes version to 0.1.14 ⚠ Bump Kubernetes version to 1.14 Mar 29, 2019
@DirectXMan12
Copy link
Contributor

woo hoo!

I'll do a double check of this a bit later, but thanks for putting this together.

@justaugustus
Copy link
Member

Could we bump these to 1.14.1 instead?

@vincepri
Copy link
Member

@adracus Are you still working on this update? Otherwise I'm happy to pick this up

@adracus adracus force-pushed the feature.kubernetes-1.14 branch from 16c1164 to 038d2c8 Compare April 23, 2019 20:35
@adracus
Copy link
Contributor Author

adracus commented Apr 23, 2019

Sorry for the delay, Easter and GoT was happening :) Bumped the version to 1.14.1 as requested.

@justaugustus
Copy link
Member

Thanks Axel!

@adracus adracus force-pushed the feature.kubernetes-1.14 branch from 038d2c8 to 090a42a Compare April 24, 2019 11:15
@rfranzke
Copy link

rfranzke commented May 8, 2019

Can we expect this to be merged anytime soon?

@mengqiy
Copy link
Member

mengqiy commented May 9, 2019

We will merge #414 probably sometime this week. And then bump to 1.14 (this PR).

@tamalsaha
Copy link
Contributor

@adracus, I wonder if you could rebase and fix the conflicts? We would like to use 1.14.x, too! :)

@adracus adracus force-pushed the feature.kubernetes-1.14 branch from 090a42a to f2da596 Compare May 14, 2019 17:16
@adracus
Copy link
Contributor Author

adracus commented May 14, 2019

@tamalsaha Done! However I wonder why does controller runtime use both dep and go modules... Hope this specifies the right dependencies.

@DirectXMan12
Copy link
Contributor

We're keeping around both since dep doesn't understand go modules yet and we don't want to break people. The plan is to drop dep support when Go modules goes stable in Go 1.13

adracus and others added 2 commits May 15, 2019 15:55
@adracus @DirectXMan12
Bump Kubernetes version to 1.14
71cf6f6 
implement and test patch options
implement new metrics provider API
@DirectXMan12
Bump test k8s version to 1.14.1
c8856cc 
This bumps the testing version of the kubebuilder tools to v1.14
@DirectXMan12 DirectXMan12 force-pushed the feature.kubernetes-1.14 branch from f2da596 to c8856cc Compare May 15, 2019 22:57
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 15, 2019
@DirectXMan12
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2019
@mengqiy mengqiy added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: adracus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6fc7baa into kubernetes-sigs:master May 15, 2019
@ingvagabund ingvagabund mentioned this pull request May 22, 2019
Merged
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
@k8s-ci-robot
Merge pull request #376 from droot/book/dep-update-command
22f919b 
updated docs for updating the vendor deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@DirectXMan12 DirectXMan12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@adracus @DirectXMan12 @justaugustus @vincepri @rfranzke @mengqiy @tamalsaha @k8s-ci-robot