Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Implement delete collection via delete options #447

Merged
merged 1 commit into from
Jul 26, 2019
Merged

✨ Implement delete collection via delete options #447

merged 1 commit into from
Jul 26, 2019

Conversation

adracus
Copy link
Contributor

@adracus adracus commented May 26, 2019 •
edited by DirectXMan12
Loading

implement CollectionOptions in DeleteOptions that allow to issue a
DeleteCollection call under the hood

add tests + examples

Co-Authored-By: Aaron Clawson [email protected]

Edited By directxman12: function naming, rebase

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 26, 2019
@adracus adracus mentioned this pull request May 26, 2019
Closed
@DirectXMan12
Copy link
Contributor

/hold

while I be frustrating and indecisive. Don't want to make you miserable by going back and forth with myself :-P

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2019
@DirectXMan12
Copy link
Contributor

(this is on the KB 2.0.0 cross-project tracking board though, so we'll get it in before then)

@DirectXMan12 DirectXMan12 force-pushed the feature.delete-collection branch from dd782cd to acf910d Compare July 24, 2019 01:39
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2019
@DirectXMan12
Copy link
Contributor

rebased on top of #536 and edited for wording.

Should be good to go once that merged. Sorry for all the back and forth

@DirectXMan12 DirectXMan12 force-pushed the feature.delete-collection branch from acf910d to 7ca16cb Compare July 25, 2019 22:44
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2019
@adracus @MadVikingGod @DirectXMan12
✨ Implement delete collection via delete options
3b06668 
implement `CollectionOptions` in `DeleteOptions` that allow to issue a
`DeleteCollection` call under the hood

add tests + examples

Co-Authored-By: Aaron Clawson <[email protected]>
Edited-By: Solly Ross (directxman12)
@DirectXMan12 DirectXMan12 force-pushed the feature.delete-collection branch from 7ca16cb to 3b06668 Compare July 25, 2019 22:45
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 25, 2019
@mengqiy
Copy link
Member

mengqiy commented Jul 25, 2019

/lgtm
Waiting for @droot to take a look. So keeping the hold label til it's done.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2019
@droot
Copy link
Contributor

droot commented Jul 26, 2019

/lgtm

@droot droot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: adracus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@droot
Copy link
Contributor

droot commented Jul 26, 2019

Yay!!! Feels good to get this merged. This completes the client interface.

@k8s-ci-robot k8s-ci-robot merged commit bfba246 into kubernetes-sigs:master Jul 26, 2019
@alvaroaleman alvaroaleman mentioned this pull request Aug 3, 2019
Closed
@ialidzhikov ialidzhikov mentioned this pull request Aug 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@droot droot

@mengqiy mengqiy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adracus @DirectXMan12 @mengqiy @droot @k8s-ci-robot