Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Fix runtime/scheme type aliases #494

Merged

Conversation

DirectXMan12
Copy link
Contributor

pkg/runtime/scheme was supposed to maintain a type alias to make it
easier for people to upgrade and/or interact with projects written
around older versions, but apparently, I forgot to actually leave the
type alias around. This fixes that.

pkg/runtime/scheme was supposed to maintain a type alias to make it
easier for people to upgrade and/or interact with projects written
around older versions, but apparently, I forgot to actually leave the
type alias around.  This fixes that.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2019
@k8s-ci-robot k8s-ci-robot requested review from droot and pwittrock June 19, 2019 20:19
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 19, 2019
@droot droot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3bc1570 into kubernetes-sigs:master Jun 19, 2019
@DirectXMan12 DirectXMan12 deleted the bug/fix-runtime-scheme-alias branch June 28, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants