⚠️ Functional Options Redux #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
These behave more-or-less like functional options, except that a given option can be applied to more than on option type, so we can deprecate the 3 different dryrunall variants. Things with arguments generally become type aliases, with the exception of MatchingField, which gets deprecated in favor of MatchFields (a type alias to fields.Set).
For field manager, update and create also support fieldmanager, so we allow using them there. For dryrun, it's also supported by delete, so we support setting it there.
DirectXMan12
force-pushed
the
feature/functional-options-redux
branch
from
0216acb to
320b6b6
Compare
|
Ooh, this is going to affect #341 :-) |
|
should be a relatively minor tweak though. lmk if you have any issues. |
|
No worries, I can rebase. |
droot
added
the
lgtm
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
📖 add how to get auth proxy for older project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches over our functional options to actually be interfaced-based. Practically, this feels incredibly similar for users, to the point where I expect nobody will have to change their code (with the exception of Preconditions, which was a pointer).
The upsides are slightly more ergonomic options in some cases (like
client.MatchingLabels{"foo": "bar"}instead of needingclient.MatchingLabels(map[string]string{"foo": "bar"}), although the latter still works), as well as the removal of the need for separate variants for options that apply across different operations.Technically, this is a breaking change, since there are type signature changes.
Fixes #503 (see that issue for more details)