Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide default OpenAPI settings & definitions #109

Closed
olivierlemasle opened this issue Nov 17, 2022 · 0 comments · Fixed by #110
Closed

Provide default OpenAPI settings & definitions #109

olivierlemasle opened this issue Nov 17, 2022 · 0 comments · Fixed by #110
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@olivierlemasle
Copy link
Member

Since #65, custom-metrics-apiserver serves an OpenAPI spec; however, it requires a configuration and the generation by the project using custom-metrics-apiserver of OpenAPI definitions using openapi-gen.

That leads to duplicated works, each implementation project having to generate its own OpenAPI definitions.

E.g.:

  • test-adapter generates definitions here and configures OpenAPI here;
  • prometheus-adapter generates definitions here and configures OpenAPI here;
  • keda generates definitions here and configures OpenAPI here.

It seams reasonable to provide these generated OpenAPI definitions in custom-metrics-apiserver, along with default OpenAPI serving settings (and let it possible to customize it).

Any thought?

/kind feature
/assign

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 17, 2022
@olivierlemasle olivierlemasle changed the title Provide default Provide default OpenAPI settings & definitions Nov 17, 2022
@dgrisonnet dgrisonnet added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants