Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Facilitate adding the annotation on federated object to specify users intent of orphaning/not orphaning target/managed resources. #690

Closed
irfanurrehman opened this issue Mar 24, 2019 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@irfanurrehman
Copy link
Contributor

irfanurrehman commented Mar 24, 2019

What would you like to be added:
#669 moves away from the usage of orphanDependents and uses intent via an annotation on the object to signify whether the dependent resources should be orphaned or not.
This seems to be an additional step, where user will need to create the annotation on the federated object if a non default behaviour is needed.

Suggestion is to facilitate adding the annotation using kubefed2 before deletion using kubectl.
Implement kubefed2 enable-orphaning-deletion <federated-resource-name>

Why is this needed:

Ease of usage to the user.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 24, 2019
@irfanurrehman irfanurrehman added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Mar 24, 2019
@irfanurrehman
Copy link
Contributor Author

A more suitable name then enable-orphaning-deletion for the command is welcome.

@roytman
Copy link
Contributor

roytman commented Jun 17, 2019

If nobody is working on it, I'll do it

@marun
Copy link
Contributor

marun commented Jun 18, 2019

@roytman Hi! You're welcome to work on this. The suggested form would be more like:

kubefedctl orphaning-deletion <enable|disable> <resource type> <resource name> [-n namespace]

Alternately, you could look at one of the higher-priority items in the v0.2.0 (beta2) milestone.

@marun
Copy link
Contributor

marun commented Jul 19, 2019

Fixed by #1008

@marun marun closed this as completed Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants