Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping patch versions ? #10802

Closed
olevitt opened this issue Jan 17, 2024 · 3 comments · Fixed by #10850
Closed

Skipping patch versions ? #10802

olevitt opened this issue Jan 17, 2024 · 3 comments · Fixed by #10850
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@olevitt
Copy link
Contributor

olevitt commented Jan 17, 2024

What happened?

Documentation (https://github.com/kubernetes-sigs/kubespray/blob/master/docs/upgrades.md) links to this reply : #3849 (comment) that states that skipping versions is not supported.
Does this also apply to patches releases ? e.g 2.23.2 was just released and 2.24.0 is set to be released in 2 days. Could someone on 2.23.1 (or 2.23.0) skip the 2.23.2 and upgrade directly to 2.24.0 ?

What did you expect to happen?

N/A

How can we reproduce it (as minimally and precisely as possible)?

N/A

OS

N/A

Version of Ansible

2.23.1

Version of Python

N/A

Version of Kubespray (commit)

N/A

Network plugin used

calico

Full inventory with variables

No response

Command used to invoke ansible

No response

Output of ansible run

No response

Anything else we need to know

No response

@olevitt olevitt added the kind/bug Categorizes issue or PR as related to a bug. label Jan 17, 2024
@VannTen
Copy link
Contributor

VannTen commented Jan 17, 2024

The same documentation mentions going to 2.6.0 to 2.7.0, so that points to skipping patch releases as supported.
I guess that could use a more explicit mention

@VannTen
Copy link
Contributor

VannTen commented Jan 22, 2024

@yankay @floryut I think it should works right now, but that's probably worth making it explicit and if upgrades between 2.N.X and 2.(N+1).Y does not work, that should be a bug.
wdyt ?

@yankay
Copy link
Member

yankay commented Jan 30, 2024

@yankay @floryut I think it should works right now, but that's probably worth making it explicit and if upgrades between 2.N.X and 2.(N+1).Y does not work, that should be a bug. wdyt ?

HI @VannTen

Yes, I think it's a design goal. However, there is a lack of automatic CI to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants