Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove starlark dependencies from api module #3943

Closed
KnVerey opened this issue Jun 1, 2021 · 4 comments
Closed

Remove starlark dependencies from api module #3943

KnVerey opened this issue Jun 1, 2021 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Jun 1, 2021

As requested in kubernetes/kubernetes#98946, we need to make it possible to use Kustomize as a library without pulling in a starlark dependency. Starlark functionality should remain available in the standalone kustomize binary, but this should be done via injection so that it does not affect kubectl. We can revisit this decision if starlark functions graduate out of alpha, but for now, we don't expose them in kubectl at all.
@KnVerey KnVerey added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 1, 2021
@mikebz
Copy link
Contributor

mikebz commented Jun 10, 2021

I think this is a great idea. In general I would probably look for limiting the number of "extension points" in kustomize because it can lead to security issues.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 8, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 8, 2021
@KnVerey KnVerey removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 25, 2021
@KnVerey
Copy link
Contributor Author

KnVerey commented Dec 21, 2021

We are instead going to remove Starlark support entirely: #4349

@KnVerey KnVerey closed this as completed Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mikebz @KnVerey @k8s-ci-robot @k8s-triage-robot