-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider deprecating configurations
field
#3945
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/lifecycle frozen |
I have been unable to successfully use the |
Thanks for the input, @kferrone. Can you please provide more detail on the challenges you're encountering in switching from configurations to openapi?
Do you mean within a given configuration tree (i.e. in both bases and overlays) or across multiple apps? For both configurations and openapi, you should only need to include it in the top layer. I understand that even this can be tedious when you manage many config sets, but as a rule we want to keep Kustomize's configuration 100% declarative, which means including everything that can affect output in the Kustomization resource.
I spoke with @natasha41575 about this, and apparently there has been some discussion in the past about passing openapi data declaratively through the KRM Functions specification. It hasn't been implemented so far, but it is useful for us to hear the feedback that this is a desired feature. I've created an issue here: #4351 |
I haven't had any success using the openapi feature. I followed this guide: I ran this command: I end up falling back to using the components:
- ../../../konfig Sounds like the only change would be simply to switch to using: openapi:
path: ../../../konfig/schema.json Taken the schema file itself doesn't literally need to be in the same directory. Would I be able to put this giant schema.json in a git repo and reference remotely? Ultimately I simply have not been successful with the OpenApi stuff yet. I haven't experimented enough either. When I did follow the guide I just didn't get the desired strategic merge effect with the array or name prefixing. Kustomize gave me no complaints either. So not really sure what I'm doing wrong here, seems like more docs and more examples would generally help a lot here. I'm also curious about what is actually deprecating here. Just the apiVersion: builtin
kind: LabelTransformer
metadata:
name: not-important-to-example
labels:
app: myApp
env: production
fieldSpecs:
- path: metadata/labels
create: true Or will kustomize in the background start fully using the openapi stuff as the main strategy and |
That sounds like a reasonable request to me. @natasha41575 has been thinking about this, and has decided to tackle this issue, #3944 and #3418 holistically. She will be preparing KEP with a detailed plan for the way forward, including migration path for all three existing ways of doing things. Whether or not |
Adding a note that the |
Has the skip field been fully removed? I still cant seem to find any reference to it, but had some instances where it was previously working and after updating kustomize seems to no longer work. I understand the alternative is to add every resource type that should be prefixed/suffixed to a configuration specifying those types, but that seems unnecessarily complex when it seems I've come across a few issues where people are looking to leave out a single resource type from the operation. |
The configurations field is an old, pre-plugin, pre-openapi global configuration mechanism for custom resources. Since we're aiming to make the
openapi
field the blessed way of getting custom resource support (see also #3944), we should consider removing all legacy ways to do the same thing, to simplify user experience and maintenance.The text was updated successfully, but these errors were encountered: