-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-784: Update design-details #4337
KEP-784: Update design-details #4337
Conversation
aroradaman
commented
Nov 17, 2023
- One-line PR description: Updated template with PRR Questionnaire
- Issue link: Graduate the kube-proxy ComponentConfig #784
- Other comments:
c365eb8
to
256c437
Compare
| Field | Comments | | ||
|---------|-----------------------------------------------------| | ||
| Linux | new section for linux (platform-specific) options | | ||
| Windows | new section for windows (platform-specific) options | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the plan is to get rid of windows directly, is not likely anybody is going to work on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we talked about this in SIG Network this week.
At any rate, having all the Windows-specific config in its own section(s) could be a step toward moving winkernel out of tree, if that eventually becomes the plan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were going to do like with userspace proxy, just remove it completely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone has to maintain windows service proxying somewhere.
At any rate, my point was that if we eventually want the windows proxy code to be not-in-tree (whether that's because it's somewhere else, or because it no longer exists), then having all the windows-specific config all in one place wil lmake it easier to delete it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe update the KEP title to something like "Kube Proxy component configuration updates and graduation"?
256c437
to
d489b5a
Compare
/approve |
d489b5a
to
f79c15d
Compare
/lgtm
#4337 (comment) sounds like he's ok |
@wojtek-t This is an old KEP that pre-dates PRRs so we need to add one belatedly now that we're getting back to it... |
Yeah - I remember this one. I'm happy to review this, but it needs to be filled in :) @aroradaman - can you please fill in the PRR questions? It should be relatively simple (also for reference: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/785-scheduler-component-config-api is somewhat similar for a different component). |
f79c15d
to
2b2534f
Compare
89f83e4
to
1102e82
Compare
c5e16e7
to
188fe04
Compare
Signed-off-by: Daman Arora <[email protected]>
Signed-off-by: Daman Arora <[email protected]>
188fe04
to
c6895ad
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aroradaman, danwinship, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |