Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the judgment mode to remove redundant transformations #9591

Closed
Fish-pro opened this issue Feb 7, 2023 · 1 comment · Fixed by #9588
Closed

Optimize the judgment mode to remove redundant transformations #9591

Fish-pro opened this issue Feb 7, 2023 · 1 comment · Fixed by #9588
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@Fish-pro
Copy link
Member

Fish-pro commented Feb 7, 2023

When I read the code, I found some useless judgments and redundant casts in the code, so I suggested modifying them to reduce the paths

/remove-kind feature
@Fish-pro Fish-pro added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Feb 7, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fish-pro Fish-pro mentioned this issue Feb 7, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
[SIG Network] Ingress NGINX
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize the judgment mode to remove redundant transformations Fish-pro/ingress-nginx
2 participants
@k8s-ci-robot @Fish-pro