Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UX for upgrade node experimental-control-plane #1071

Closed
fabriziopandini opened this issue Aug 22, 2018 · 13 comments
Closed

Improve UX for upgrade node experimental-control-plane #1071

fabriziopandini opened this issue Aug 22, 2018 · 13 comments
Assignees
@fabriziopandini
Labels
area/HA area/upgrades area/UX kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v1.16

Comments

@fabriziopandini
Copy link
Member

fabriziopandini commented Aug 22, 2018 •
edited
Loading

kubernetes/kubernetes#66973 implemented upgrade for secondary instances of the control plane via the new command kubeadm upgrade node experimental-control-plane.

This approach isolates the alpha feature from the main kubeadm workflows, but gives extra works to the users.

Once join --control-plane became not experimental we should review the approach to upgrades as well, perhaps detecting and triggering automatically upgrade of secondary instances of the control plane as a step of a comprehensive kubeadm upgrade node action

See this comments on the PR for more background
@fabriziopandini fabriziopandini added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/HA area/upgrades area/UX kind/feature Categorizes issue or PR as related to a new feature. labels Aug 22, 2018
@fabriziopandini fabriziopandini self-assigned this Aug 22, 2018
@fabriziopandini fabriziopandini mentioned this issue Aug 22, 2018
Merged
@timothysc
Copy link
Member

/assign @liztio

@timothysc timothysc added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 22, 2018
@timothysc timothysc added this to the v1.13 milestone Aug 22, 2018
@timothysc
Copy link
Member

Thanks for filing @fabriziopandini

@timothysc
Copy link
Member

@fabriziopandini can we close?

@timothysc timothysc modified the milestones: v1.13, v1.14 Nov 16, 2018
@fabriziopandini
Copy link
Member Author

No. Users are still required to do two actions for upgrading control-plane nodes ATM

@fabriziopandini fabriziopandini mentioned this issue Jan 30, 2019
Closed
25 tasks
@MalloZup
Copy link

MalloZup commented Feb 3, 2019 •
edited
Loading

@fabriziopandini i will take this one.

@fabriziopandini
Copy link
Member Author

kk
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Feb 4, 2019
@yuexiao-wang
Copy link

I will take this issue this week after talking with @MalloZup

@fabriziopandini
Copy link
Member Author

@yuexiao-wang when do you plan to send PR for this issue (I'm updating state for Tracking issue for Certificates copy for join --control-plane)

@fabriziopandini
Copy link
Member Author

@yuexiao-wang as discussed in slack we are punting this to v1.15 because HA will not make beta in V1.14

@fabriziopandini fabriziopandini modified the milestones: v1.14, v1.15 Feb 24, 2019
@yuexiao-wang
Copy link

Got it

@neolit123 neolit123 removed the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Apr 22, 2019
@fabriziopandini fabriziopandini mentioned this issue May 15, 2019
Closed
8 tasks
@fabriziopandini
Copy link
Member Author

/lifecycle active
@timothysc @neolit123 @Yago @ereslibre @rosti

For upgrades on nodes now we have two commands now:

  1. kubeadm upgrade node config to be run on all nodes
  2. kubeadm upgrade node experimental-control-plane to be run on control-plane nodes only

My proposal is to:
a. Merge the two commands into kubeadm upgrade node, implementing it as a command with two phases, kubelet-config and control-plane
c. Deprecate 1. (subject to GA constraints), pointing users to use a. (or a. phase)
b. Remove 2. (or deprecate as for 1.) (edited)

CONS: for a transitory period we will have kubeadm upgrade node command with phases subcommand + the olds config / experimental-control-plane deprecated subcommands, that is kind of weird

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label May 18, 2019
@neolit123
Copy link
Member

i was thinking that we should punt the upgrade phases work to 1.16.
but if you think otherwise, it's fine.

@fabriziopandini fabriziopandini mentioned this issue May 27, 2019
Merged
@neolit123 neolit123 modified the milestones: v1.15, v1.16 Jun 3, 2019
@neolit123
Copy link
Member

this seems to be done. upgrade phases for "apply" has a separate ticket.
please reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabriziopandini fabriziopandini

Labels
area/HA area/upgrades area/UX kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v1.16
Development

No branches or pull requests
7 participants
@timothysc @neolit123 @fabriziopandini @MalloZup @yuexiao-wang @k8s-ci-robot @liztio