Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If one enables PodLogsQuerySplitStreams and aims to access logs without stream, a validation error occurs #128709

Closed
kannon92 opened this issue Nov 8, 2024 · 4 comments · Fixed by #128712
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone

Comments

@kannon92
Copy link
Contributor

kannon92 commented Nov 8, 2024

What happened?

We saw this in our alpha jobs.

https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-kubernetes-e2e-kind-alpha-features/1854662086911594496

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/128680/pull-e2e-gci-gce-alpha-enabled-default/1854616736976867328

What did you expect to happen?

One should be able to run the following command with this feature gate on:

kehannon@kehannon-thinkpadp1gen4i:~/Work/KubeExamples$ k get --raw /api/v1/namespaces/default/pods/example/log
The PodLogOptions "example" is invalid: stream: Required value: must be specified

How can we reproduce it (as minimally and precisely as possible)?

Start a cluster with PodLogsQuerySplitStreams enabled.

Anything else we need to know?

No response

Kubernetes version

1.32

Cloud provider

NA

OS version

No response

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

@kannon92 kannon92 added the kind/bug Categorizes issue or PR as related to a bug. label Nov 8, 2024
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 8, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kannon92
Copy link
Contributor Author

kannon92 commented Nov 8, 2024

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 8, 2024
@kannon92
Copy link
Contributor Author

kannon92 commented Nov 8, 2024

The PR that caused this is #127360.

@dims
Copy link
Member

dims commented Nov 8, 2024

/priority critical-urgent
/kind failing-test

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 8, 2024
@dims dims added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Nov 8, 2024
@kubernetes kubernetes deleted a comment from k8s-ci-robot Nov 8, 2024
@liggitt liggitt added this to the v1.32 milestone Nov 9, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in SIG Node Bugs Nov 9, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in SIG Node CI/Test Board Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants