Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding OWNERS for federation #28042

Merged
merged 1 commit into from
Jun 27, 2016
Merged

Adding OWNERS for federation #28042

merged 1 commit into from
Jun 27, 2016

Conversation

nikhiljindal
Copy link
Contributor

Adding OWNERS for the federation dir

cc @kubernetes/sig-cluster-federation

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 24, 2016
@ghost ghost added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 24, 2016
@ghost ghost self-assigned this Jun 24, 2016
@ghost
Copy link

ghost commented Jun 24, 2016

LGTM

@ghost ghost added lgtm "Looks good to me", indicates that a PR is ready to be merged. team/control-plane and removed release-note-label-needed labels Jun 24, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 24, 2016

GCE e2e build/test passed for commit b1021db.

@philips
Copy link
Contributor

philips commented Jun 24, 2016

Where is the file format of the OWNERS file documented?

@philips
Copy link
Contributor

philips commented Jun 24, 2016

Currently OWNERS files docs say it is "not implemented" https://github.com/kubernetes/kubernetes/blob/master/docs/devel/owners.md#owners-files

@colhom
Copy link

colhom commented Jun 24, 2016

@quinton-hoole @nikhiljindal can I be on this list?

@ghost
Copy link

ghost commented Jun 24, 2016

@colhom Sure, want to send me a PR?

@colhom colhom mentioned this pull request Jun 25, 2016
Merged
@nikhiljindal
Copy link
Contributor Author

@philips: Yes that design (for blocking all changes to a dir until someone in the OWNERS file has approved) is not yet implemented.

My understanding (which could be wrong) is that the bot looks at the OWNERS file to assign PR reviews. That was my understanding after looking at #27402.

This is what the munger README says:

blunderbuss - assigned PRs to individuals based on the contents of OWNERS files in the main repo

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 7d57bea into kubernetes:master Jun 27, 2016
k8s-github-robot pushed a commit that referenced this pull request Jul 26, 2016
Merge pull request #28062 from colhom/add-colhom-federation-owners
d038e22 
Automatic merge from submit-queue

Add colhom to federation OWNERS

Depends on #28042

\cc @quinton-hoole 

[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikhiljindal @k8s-bot @philips @colhom @k8s-github-robot @googlebot