Able to quick create a HA cluster by kube-up.sh centos provider #39462
Conversation
|
Hi @Shawyeok. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: no
|
This change is |
k8s-github-robot
added
size/L
|
I signed it! |
k8s-ci-robot
added
cncf-cla: yes
|
@xiaoping378 Would you mind take a look about this PR? |
|
/cc @kubernetes/sig-cluster-lifecycle-misc |
|
It looks like your PR only affect the centos provider. If that was the intent, please update the PR description and the release note to make it clear to reviewers and users. Thanks! |
Shawyeok
changed the title
|
@roberthbailey OK, I've changed that. Maybe I should add support for ubuntu provider and others later. |
|
@Shawyeok - doing it in multiple PRs sounds like the best path forward. |
|
@roberthbailey Yeah, I think so. If a PR is too large, it's hard to review or find bug in it. |
|
@roberthbailey @zmerlynn I added two more commits to fix a problem. What should I do to make this PR move forward? |
|
/lgtm |
|
@Shawyeok: you can't LGTM your own PR. In response to this comment:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mikedanese @jbeda @eparis Would you mind take a look about this PR? |
|
Please squash your commits. |
|
@roberthbailey OK, I got squashed my commits. |
|
@Shawyeok |
|
@jszczepkowski I'm check the PR for quick create a HA cluster using centos provider. e.g. code below will crate a HA k8s cluster (replicated api servers, etcd cluster, leader elect) #!/bin/bash
# file: cluster/env.sh
# define your master machines in comma separate: <user0>@<ip0> <user1>@<ip1> <user2>@<ip2>
export MASTERS="[email protected] [email protected] [email protected]"
# define your node machines in comma separate: <user0>@<ip0> <user1>@<ip1> <user2>@<ip2>
export NODES="[email protected] [email protected]"
export KUBERNETES_PROVIDER=centos
export CERT_GROUP=ec2-user
# ssh-agent
eval `ssh-agent -s` && ssh-add ~/.ssh/<my-private-key>.pem$ cd cluster
$ ./kube-up.shAs I said above #39430 , |
|
We would like to make kops work (of course), and I'm sure team-kubeadm would love to make kubeadm work also. For kops, it's Route53, right? If you have time it would be great to know if the following are supported in AWS cn-north:
|
|
@justinsb Route53 doesn't serve on aws |
|
|
||
| # By default, etcd cluster will use etcd-discovery | ||
| # https://github.com/coreos/etcd/blob/master/Documentation/op-guide/clustering.md#etcd-discovery | ||
| export NUM_ETCD_NODES=${NUM_MASTERS} |
There was a problem hiding this comment.
Variables should be in the following format: "${VALUE}"
So, here you should have: NUM_ETCD_NODES="${NUM_MASTERS}"
Please, update also other places.
|
@Shawyeok: Run |
k8s-github-robot
removed
lgtm
|
/approve |
k8s-ci-robot
added
the
lgtm
k8s-github-robot
added
the
approved
Fix: cannot get default master advertise address correctly Set default value of NUM_MASTERS and NUM_NODES by MASTERS and NODES themself Code cleanup and documented Using runtime reconfiguration for etcd cluster instead of etcd discovery Add exceptions for verify-flags
k8s-github-robot
removed
lgtm
|
@zmerlynn I've missed run Change of Sorry for delay. |
|
@zmerlynn Now all checks were passed, need |
|
/approve |
k8s-ci-robot
added
the
lgtm
k8s-github-robot
added
approved
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
|
I see the official said 1.5 version integrated HA, but it seems only in gce use, we use the centos, so I see your PR, So I tested it，download the k8s 1.5.2 source, I will cluster/centos directory file replacement for you to modify, and then use kube-up to start the test, but failed, the following is my steps:
And then it's over. I would like to ask you this installation method is correct? |
|
The problem is |
|
@Shawyeok And stop in here.I found that there is a problem with the docker start.Can you leave a contact, like qq, or a tutorial for my reference. |
|
Would you mind provide some logs of |
|
There is a docker dependencies problems in centos: It cause by a runtime lib which docker depend is missing. You can resolve it as below: |
|
@Shawyeok |
|
Actually, I don't understand your question. If you want to know about the principle of |
Automatic merge from submit-queue Centos provider: generate SSL certificates for etcd cluster. **What this PR does / why we need it**: Support secure etcd cluster for centos provider, generate SSL certificates for etcd in default. Running it w/o SSL is exposing cluster data to everyone and is not recommended. [#39462](#39462 (comment)) /cc @jszczepkowski @zmerlynn **Release note**: ```release-note Support secure etcd cluster for centos provider. ```
Make
kube-up.shcentos providersupport quick create a HA cluster, as I said above #39430, it's more flexible thankopsorkubeadmfor some people in a limited network region.I'm new to k8s dev, so if this pull request need to change, please let me know.