Update dependencies: aws-sdk-go to 1.6.10; also cadvisor #40095
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
Jenkins Bazel Build failed for commit 9737b41. Full PR test history. cc @dashpole The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-github-robot
added
size/XXL
|
Jenkins Kubemark GCE e2e failed for commit ca23355. Full PR test history. cc @dashpole The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Jenkins GCI GCE e2e failed for commit ca23355. Full PR test history. cc @dashpole The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Jenkins GCE etcd3 e2e failed for commit ca23355. Full PR test history. cc @dashpole The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Jenkins GCE e2e failed for commit ca23355. Full PR test history. cc @dashpole The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I think we should consider splitting the aws update into a separate PR. Also, the cAdvisor update to the AWS API didn't change cAdvisor code at all, so I think you should be able to update cAdvisor without the AWS dependency. |
|
Jenkins unit/integration failed for commit ca23355. Full PR test history. cc @dashpole The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Jenkins verification failed for commit 9737b41. Full PR test history. cc @dashpole The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I don't know how you got it to go green, but I'm not going to look a magic gift horse in the mouth. /lgtm |
k8s-ci-robot
added
the
lgtm
|
Oh, its going to remove the lgtm because I dont have a release note |
k8s-github-robot
added
the
do-not-merge
justinsb
changed the title
justinsb
added
release-note
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Jenkins GKE smoke e2e failed for commit a739333. Full PR test history. cc @dashpole The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Jenkins GCI GKE smoke e2e failed for commit a739333. Full PR test history. cc @dashpole The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Jenkins kops AWS e2e failed for commit a739333. Full PR test history. cc @dashpole The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 40105, 40095) |
|
Jenkins CRI GCE e2e failed for commit a739333. Full PR test history. cc @dashpole The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@calebamiles this is the PR that updated the cAdvisor dependency. However, IIRC, this introduced problems with the AWS builds, and may not be a clean cherrypick. @justinb, is this safe to cherrypick into 1.4? |
|
Updating aws-sdk-go should be fine. I don't believe we had any genuine problems, just problems with godeps. I presume the motivation is the cadvisor fixes? |
|
@justinsb yes, specifically a fix that prevents it from leaking goroutines if the user doesnt have the "find" command. |
|
whoa this is pretty big is it necessary for 1.4 |
|
updating the deps in the release branches is not exactly simple/fun, is this fixing a specific bug |
|
This fixes cadvisor #1558. I am not quite sure what constitutes a "neccessary" bug fix. This issue is pretty major for those experiencing it, as it leaks goroutines if the image doesnt have GNU find. |
|
is something shelling out to |
|
Yes, the way that we estimate inode usage inside a container's writeable layer uses the find command. |
|
ok I guess we can cherrypick, thanks for the explanation, i might send a PR to cadvisor :) |
|
If you are curious, we are considering doing this in pure go instead of using find. google/cadvisor#1576 |
|
oh sweet!
…On Wed, Feb 1, 2017 at 10:16 AM David Ashpole ***@***.***> wrote:
If you are curious, we are considering doing this in pure go instead of
using find. google/cadvisor#1576
<google/cadvisor#1576>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40095 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABYNbK1CMnaGr_sHXKA9tXbwFE7C3w0gks5rYMvkgaJpZM4LnQ3J>
.
|
|
@jessfraz any idea if this was cherrypicked? |
Automatic merge from submit-queue [Release 1.5] Update cadvisor godeps to v0.25.0 This PR updates the cAdvisor Godeps for the 1.5 branch. This includes a number of critical bugfixes including: [cadvisor#1558](google/cadvisor#1558), [cadvisor#1573](google/cadvisor#1573) This is a large change on account of the aws dependency update. However, many affected users have requested that this be cherrypicked into 1.5 and 1.4 (coming soon) ```release-note - Disable thin_ls due to excessive iops - Ignore .mount cgroups, fixing dissappearing stats - Fix wc goroutine leak - Update aws-sdk-go dependency to 1.6.10 ``` cc @calebamiles [remember this?](#40095 (comment)) @jessfraz @timstclair
updating cadvisor mainly to include this bugfix #1558
Because cadvisor vendors a newer version of aws than kubernetes, the aws dependency needed to be updated as well.
cc: @justinsb @zmerlynn @timstclair