Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go-autorest to v11.1.2 #77070

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Upgrade go-autorest to v11.1.2 #77070

merged 1 commit into from
Apr 25, 2019

Conversation

feiskyer
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug

What this PR does / why we need it:

According to Azure/go-autorest#357, the timeout set in context doesn't take effect and 15min is always used for long running operations.

This PR upgradse the version of go-autorest to 11.1.2 so as to fix the issue.

Which issue(s) this PR fixes:

Fixes #75579

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Upgrade go-autorest to v11.1.2

/priority important-soon
/assign @liggitt @andyzhangx

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 25, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 25, 2019
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, caesarxuchao and a team April 25, 2019 12:55
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Apr 25, 2019
@liggitt
Copy link
Member

liggitt commented Apr 25, 2019

according to Azure/go-autorest#357 (comment), this was fixed in v11.3.2, not v11.1.2

@liggitt
Copy link
Member

liggitt commented Apr 25, 2019

ah, nevermind, I see v11.1.2 was a special backport patch release - https://github.com/Azure/go-autorest/releases/tag/v11.1.2

@liggitt
Copy link
Member

liggitt commented Apr 25, 2019

/approve

will leave lgtm to @andyzhangx

dims
dims approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Looks legit :) does not add anything new.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@dims
Copy link
Member

dims commented Apr 25, 2019

oops need to let @andyzhangx take a look

/hold

@liggitt
Copy link
Member

liggitt commented Apr 25, 2019

thanks for all the effort to get these fixes in a non-disruptive way

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2019
andyzhangx
andyzhangx approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/test pull-kubernetes-e2e-aks-engine-azure

@dims
Copy link
Member

dims commented Apr 25, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9e29c3e into kubernetes:master Apr 25, 2019
@feiskyer feiskyer deleted the autorest-update branch April 25, 2019 14:18
@feiskyer
Copy link
Member Author

thanks, @liggitt and @dims.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@dims dims dims approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@dims dims

@liggitt liggitt

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long running operations may fail because of go-autorest bugs
5 participants
@feiskyer @liggitt @k8s-ci-robot @dims @andyzhangx