-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISO: Add CONFIG_DM_MULTIPATH=y to aarch64 and x86_64 config #18277
Conversation
Welcome @albertofaria! |
Hi @albertofaria. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
Can we get an ok-to-test on this? |
Hi @albertofaria, there are two ISO PRs ahead of you I'm working on merging, I should be able to get this merged early next week |
We happen to need this for [1], where we use minikube for testing. [1] https://gitlab.com/subprovisioner/subprovisioner Signed-off-by: Alberto Faria <[email protected]>
ok-to-build-iso |
Hi @albertofaria, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 50.8s 55.2s 50.6s 51.6s 53.7s Times for minikube ingress: 24.0s 25.8s 22.5s 26.0s 23.0s docker driver with docker runtime
Times for minikube start: 21.8s 22.8s 25.8s 23.0s 22.8s Times for minikube ingress: 19.8s 20.3s 20.3s 19.3s 19.8s docker driver with containerd runtime
Times for minikube ingress: 31.3s 30.8s 31.3s 30.8s 30.8s Times for minikube (PR 18277) start: 23.9s 24.6s 22.8s 21.4s 24.4s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: albertofaria, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We happen to need this for [1], where we use minikube for testing.
[1] https://gitlab.com/subprovisioner/subprovisioner