Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quobyte volumes in docs #1067

Merged

Conversation

johscheuer
Copy link
Contributor

@johscheuer johscheuer commented Aug 19, 2016

Now to the right branch #1061

Thanks @pwittrock :)


This change is Reviewable

@johscheuer
Copy link
Contributor Author

Ping @thockin

@johscheuer
Copy link
Contributor Author

The failed check seems unrelated to the PR:

The command "git config --global user.email ${GIT_EMAIL}" exited with 1.
$ git config --global user.name "${GIT_NAME}"
...
$ git push
warning: push.default is unset; its implicit value is changing in
Git 2.0 from 'matching' to 'simple'. To squelch this message
and maintain the current behavior after the default changes, use:
  git config --global push.default matching
To squelch this message and adopt the new behavior now, use:
  git config --global push.default simple
See 'git help config' and search for 'push.default' for further information.
(the 'simple' mode was introduced in Git 1.7.11. Use the similar mode
'current' instead of 'simple' if you sometimes use older versions of Git)
remote: Anonymous access to kubernetes-v1-4/kubernetes-v1-4.github.io.git denied.
fatal: Authentication failed for 'https://:@github.com/kubernetes-v1-4/kubernetes-v1-4.github.io.git/'
The command "git push" exited with 128.

@devin-donnelly
Copy link
Contributor

This looks fine; I'm not sure why that Travis check failed. @jeffmendoza , any insight?

Otherwise I can just merge this.

@jeffmendoza
Copy link
Contributor

@jaredbhatti The release-1.4 branch needs it credentials updated as well.

@janetkuo
Copy link
Member

I hit this also and filed issue #1124

@janetkuo janetkuo added this to the 1.4 milestone Sep 2, 2016
@janetkuo
Copy link
Member

janetkuo commented Sep 2, 2016

The travis scripts is updated. The build should succeed after rebasing.

@janetkuo
Copy link
Member

janetkuo commented Sep 7, 2016

I merged #1159 so after another rebase the travis should pass

@janetkuo
Copy link
Member

janetkuo commented Sep 7, 2016

Oh wait, I re-run the build and it passed. No need to rebase.

@saad-ali
Copy link
Member

saad-ali commented Sep 7, 2016

LGTM @kubernetes/docs for final sign-off.

@thockin
Copy link
Member

thockin commented Sep 9, 2016

@devin-donnelly @jaredbhatti for 1.4

@devin-donnelly
Copy link
Contributor

Docs LGTM. Merging to release-1.4. Thanks, everybody.

@devin-donnelly devin-donnelly merged commit 45e2574 into kubernetes:release-1.4 Sep 9, 2016
mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Sep 22, 2022
add fuzz testing blog post

Signed-off-by: William Morgan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants