Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a ref doc for scheduled jobs #1111

Closed
wants to merge 2 commits into from
Closed

Create a ref doc for scheduled jobs #1111

wants to merge 2 commits into from

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Aug 26, 2016 •
edited
Loading

Update: superseded by #1123 (already merged into release-1.4 branch); however this PR adds a test for the example file, which is required in master branch (the tests don't exist in release-1.4 branch)

Preview at http://janetkuo.github.io/docs/user-guide/scheduled-jobs/

Ref kubernetes/kubernetes#28496, kubernetes/enhancements#19

@soltysh @erictune @jaredbhatti @kubernetes/docs

This change is Reviewable

@janetkuo
Copy link
Member Author

Looks like I need to add a test for sj.yaml

@janetkuo janetkuo mentioned this pull request Aug 26, 2016
Closed
maclof
maclof reviewed Aug 26, 2016
View reviewed changes
docs/user-guide/scheduled-jobs.md
### Prerequisites

You need a working Kubernetes cluster at version >= 1.4, with batch/v2alpha1 API turned on by passing
`--runtime-config=batch/v2alpha1` while brining up the API server (see [Turn on or off an API version
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/brining/bringing

@erictune
Copy link
Member

looks good. suggestions are optional.

@janetkuo janetkuo mentioned this pull request Aug 29, 2016
Merged
@janetkuo
Copy link
Member Author

This shouldn't target master branch so created #1123 that targets 1.4 branch

@janetkuo
Copy link
Member Author

We still need the 2nd commit, but it can't be added to 1.4 branch (the example file test doesn't exist there)

@soltysh soltysh mentioned this pull request Aug 31, 2016
Closed
16 tasks
@soltysh
Copy link
Contributor

soltysh commented Sep 1, 2016

@janetkuo I assume you'll be copying the entire contents from 1.4 branch, right?

@janetkuo
Copy link
Member Author

janetkuo commented Sep 1, 2016

@soltysh yes I will, or we'll simply rebase release-1.4 into master branch (in batch).

@janetkuo janetkuo added this to the 1.4 milestone Sep 2, 2016
@devin-donnelly devin-donnelly added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. Docs Review: Open Issues labels Sep 9, 2016
@devin-donnelly devin-donnelly self-assigned this Sep 9, 2016
@devin-donnelly
Copy link
Contributor

Janet, since we have a PR for the actual docs changes that targets release-1.4, do we want to pare down this PR to have just the example .yaml file and associated test?

@janetkuo
Copy link
Member Author

janetkuo commented Sep 9, 2016

Actually we can close this since the test was added to release-1.4 branch recently.

@janetkuo janetkuo closed this Sep 9, 2016
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this pull request Dec 4, 2023
@iamNoah1 @gdenn
@jihoon-seo @christianhuening @ohdle @mkorbi @DaveVentura @DavidWagnerDO @bcubk
Merge dev-de into main (for the first German localization live versio…
420ef5b 
…n) (kubernetes#1463)

* Settings and initial contents for German localization (kubernetes#347)

* first shot

* WIP german contribution index file

* finalized contribution index, add de.toml

* add contentDir to de config section in config.toml

* change request from catherine

* finalizing style guide

* change request from David and Catherine

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

* [de] Fix typo in _index.md

* first shot

* change requests

* [de] Add localization cloud computing (kubernetes#711)

* [de] Add localization cloud computing

* [de] Add missing title meta inf

* [de] Adjust wording in cloud computing

* [de] Adjust wording cloud computing

Co-authored-by: Noah Ispas <[email protected]>

Co-authored-by: Noah Ispas <[email protected]>

* update terms to completed (kubernetes#725)

* update terms to completed

* Update content/de/agile_software_development.md

Co-authored-by: Jihoon Seo <[email protected]>

* Update cloud_computing.md

Co-authored-by: Jihoon Seo <[email protected]>

* localize feedback section

* [de] Fix template title for agile software dev (kubernetes#731)

* Add german translation for API Gateway (kubernetes#732)

* Add german translation for API Gateway

Add german translation for API Gateway. Solves kubernetes#507

* Update api_gateway.md

fixed all found typos by

* Update api_gateway.md

small wording adjustment, changes state

Co-authored-by: Noah Ispas <[email protected]>

* [de] Add localization for "abstraction"

* [de] Remove whitespaces

* [de] Remove redundant information

* [de] Rephrase sentence

* [de] Rephrase sentence

* [de] Remove white spaces

* [de] Add localization cloud native tech

* Incorporate suggested change

Co-authored-by: Noah Ispas <[email protected]>

* Incorporate suggested change

Co-authored-by: Noah Ispas <[email protected]>

* Incorporate suggested change

Co-authored-by: Noah Ispas <[email protected]>

* Incorporate suggested change to title

* Update cloud_native_tech.md

* rename files, add semantic line breaks, empty lines (kubernetes#974)

* rename files, add semantic line breaks, empty lines

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

* [DE] Take Over Cloud Native Security localization (kubernetes#990)

* add cloud native sec

Signed-off-by: Max Körbächer <[email protected]>
Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

* edits, semantic line breaks

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

* change requests from Jihoon

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

* change requests from david

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

* change requests from david

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

* Update content/de/cloud-native-security.md

Co-authored-by: DaveVentura <[email protected]>

* Update content/de/cloud-native-security.md

Co-authored-by: DaveVentura <[email protected]>

Co-authored-by: Max Körbächer <[email protected]>
Co-authored-by: DaveVentura <[email protected]>

* german localize cloud native apps (kubernetes#1085)

* add german localisation for cloud native apps

* add .md

* Apply suggestions from code review

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: DaveVentura <[email protected]>

* apply change requests - remove redundancy

* Update content/de/cloud-native-apps.md

Signed-off-by: Noah Ispas <[email protected]>

* Update content/de/cloud-native-apps.md

Signed-off-by: Noah Ispas <[email protected]>

Signed-off-by: DaveVentura <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: David Wagner <[email protected]>
Co-authored-by: Noah Ispas <[email protected]>

* [DE] Add german definition for canary deployment (kubernetes#1247)

* [de] Add german definition for canary deployment

Signed-off-by: Baris Cubukcuoglu <[email protected]>
Co-authored-by: Noah Ispas <[email protected]>

* Update content/de/canary_deployment.md

Signed-off-by: Noah Ispas <[email protected]>

* Update content/de/canary_deployment.md

Co-authored-by: DaveVentura <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>

* Update content/de/canary_deployment.md

Signed-off-by: Noah Ispas <[email protected]>

Signed-off-by: Baris Cubukcuoglu <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: Noah Ispas <[email protected]>
Co-authored-by: Noah Ispas <[email protected]>
Co-authored-by: DaveVentura <[email protected]>

* german autoscaling localization (kubernetes#1111)

* add german autoscaling localisation

* Update content/de/autoscaling.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: DaveVentura <[email protected]>

* Update content/de/autoscaling.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: DaveVentura <[email protected]>

* Update content/de/autoscaling.md

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: DaveVentura <[email protected]>

* change requests

* Update content/de/autoscaling.md

Signed-off-by: Noah Ispas <[email protected]>

Signed-off-by: DaveVentura <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: Noah Ispas <[email protected]>
Co-authored-by: Noah Ispas <[email protected]>

* corrects filename

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

* correct wording (kubernetes#1355)

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

* [localization/german] Add localization for API (kubernetes#1055)

* [localization/german] Add localization for API
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: DaveVentura <[email protected]>

* fix filename

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

* [DE] Localization of Blue Green Deployment (kubernetes#1342)

* first shot

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

* localize headers

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

* Update content/de/blue-green-deployment.md

Co-authored-by: DaveVentura <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>

* Update content/de/blue-green-deployment.md

Co-authored-by: DaveVentura <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>

* Update content/de/blue-green-deployment.md

Co-authored-by: DaveVentura <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>

* Update content/de/blue-green-deployment.md

Co-authored-by: DaveVentura <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>

* add change requests from Baris

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: DaveVentura <[email protected]>

* change every article state to completed

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

* extend information about initializing members of german content

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>

Signed-off-by: Noah Ispas (iamNoah1) <[email protected]>
Signed-off-by: DaveVentura <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Signed-off-by: Baris Cubukcuoglu <[email protected]>
Signed-off-by: Noah Ispas <[email protected]>
Co-authored-by: Dennis Groß <[email protected]>
Co-authored-by: Jihoon Seo <[email protected]>
Co-authored-by: Christian Hüning <[email protected]>
Co-authored-by: Oliver L <[email protected]>
Co-authored-by: Max Körbächer <[email protected]>
Co-authored-by: DaveVentura <[email protected]>
Co-authored-by: David Wagner <[email protected]>
Co-authored-by: Baris Cubukcuoglu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erictune erictune

@devin-donnelly devin-donnelly

Labels
do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed.
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@janetkuo @erictune @soltysh @devin-donnelly @maclof @googlebot