Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs/admin/sysctls.md #1126

Closed
wants to merge 3 commits into from
Closed

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Aug 30, 2016

Here is the proposal: kubernetes/kubernetes#26057
Here is the feature: kubernetes/enhancements#34

This change is Reviewable

@sttts sttts changed the title WIP: Add docs/admin/sysctls.md Add docs/admin/sysctls.md Aug 30, 2016
@sttts sttts mentioned this pull request Aug 30, 2016
20 tasks

A number of sysctls are _namespaced_ in today's Linux kernels. This means that
they can be set independently for each pod on a node. Being namespaced is a
requirement for sysctls to be accessibly in a pod context within Kubernetes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/accessibly/accessible

@derekwaynecarr
Copy link
Member

few typos, but lgtm otherwise.

@derekwaynecarr
Copy link
Member

one last comment, squash if you agree, then LGTM

@sttts sttts force-pushed the sttts-admin-sysctls branch 2 times, most recently from 56f861a to 37ac2cc Compare September 1, 2016 07:58
@sttts
Copy link
Contributor Author

sttts commented Sep 1, 2016

Addressed last comment, squashed and rebased.

@sttts sttts added the lgtm label Sep 1, 2016
@sttts
Copy link
Contributor Author

sttts commented Sep 1, 2016

@kubernetes/docs what's the merge policy here? Anybody can just merge with a lgtm?

@devin-donnelly
Copy link
Contributor

I can merge, but if this feature isn't present until the 1.4 release, it should not be merged until then.

I'll do a docs review in the meantime.

@devin-donnelly devin-donnelly added this to the 1.4 milestone Sep 1, 2016
@sttts sttts force-pushed the sttts-admin-sysctls branch from c3ee89c to 20c8543 Compare September 5, 2016 11:55
@sttts
Copy link
Contributor Author

sttts commented Sep 5, 2016

@devin-donnelly will you cherry-pick onto the 1.4 branch? Or should I create another PR for that?

@sttts sttts mentioned this pull request Sep 8, 2016
@sttts
Copy link
Contributor Author

sttts commented Sep 8, 2016

Replaced by #1182

@sttts sttts closed this Sep 8, 2016
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this pull request Dec 4, 2023
* Adding update discussion link to guide

Signed-off-by: Catherine Paganini <[email protected]>

* Update LOCALIZATION.md

Signed-off-by: Catherine Paganini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants