Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote CronJobControllerV2 flag to GA #28229

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Promote CronJobControllerV2 flag to GA #28229

merged 2 commits into from
Jun 16, 2021

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jun 2, 2021 •
edited
Loading

This goes in pair with kubernetes/kubernetes#102529

Fixes #27394

/assign @alaypatel07

@k8s-ci-robot k8s-ci-robot added this to the 1.22 milestone Jun 2, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jun 2, 2021 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: f3101ee

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60c868fa35790b0008503efe

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 2, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 2, 2021
@soltysh soltysh mentioned this pull request Jun 2, 2021
Closed
16 tasks
@PI-Victor
Copy link
Member

i don't see this graduation being tracked for 1.22, @soltysh can you confirm that this is tracked currently for 1.22?

also hold for the pr to land in case it is.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2021
@PI-Victor
Copy link
Member

we've been talking about this in the RT team and it seems that it might need an exception to be tracked for 1.22
cc @JamesLaverack @annajung

@soltysh
Copy link
Contributor Author

soltysh commented Jun 3, 2021

we've been talking about this in the RT team and it seems that it might need an exception to be tracked for 1.22
cc @JamesLaverack @annajung

@PI-Victor good catch, it slipped my attention, I filled in the exception request in https://groups.google.com/g/kubernetes-sig-release/c/LejSpoeCiWg

alaypatel07
alaypatel07 reviewed Jun 6, 2021
View reviewed changes
Copy link
Contributor

@alaypatel07 alaypatel07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2b6b6bc7d69617afa3869b329fef5f8d2048f6e5

PI-Victor
PI-Victor suggested changes Jun 6, 2021
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
@@ -94,7 +94,8 @@ different Kubernetes components.
| `ConfigurableFSGroupPolicy` | `false` | Alpha | 1.18 | 1.19 |
| `ConfigurableFSGroupPolicy` | `true` | Beta | 1.20 | |
| `CronJobControllerV2` | `false` | Alpha | 1.20 | 1.20 |
| `CronJobControllerV2` | `true` | Beta | 1.21 | |
| `CronJobControllerV2` | `true` | Beta | 1.21 | 1.21 |
| `CronJobControllerV2` | `true` | GA | 1.22 | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is now graduating, it needs to be moved below in the table Feature gates for graduated or deprecated features

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, just to be more succinct, all CronJobControllerV2 entries from here now will go in that table.

@PI-Victor
Copy link
Member

also the description for the controller on the same page says:

CronJobControllerV2: Use an alternative implementation of the {{< glossary_tooltip text="CronJob" term_id="cronjob" >}} controller. Otherwise, version 1 of the same controller is selected. The version 2 controller provides experimental performance improvements.

Is it safe to say that The version 2 controller provides experimental performance improvements. are no longer experimental, since it's now graduating? if that's still the case, we can leave it as it is.

@PI-Victor
Copy link
Member

/assign

@soltysh soltysh mentioned this pull request Jun 15, 2021
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Jun 15, 2021

Is it safe to say that The version 2 controller provides experimental performance improvements. are no longer experimental, since it's now graduating? if that's still the case, we can leave it as it is.

Yeah, good point updated.

I'm also including a fix to #27394.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Jun 15, 2021

@PI-Victor should be all good now

@tengqm
Copy link
Contributor

tengqm commented Jun 16, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@PI-Victor
Copy link
Member

appreciate it, thank you!
/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b47e9c5622ad7d734e7a1965e8cdb5fa9b63d819

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2021
@PI-Victor
Copy link
Member

since this is now marked as tracked and the enhancement has green light, i'll go ahead and remove the hold
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit d883d03 into kubernetes:dev-1.22 Jun 16, 2021
@soltysh soltysh deleted the cronjob_fflag branch June 28, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaypatel07 alaypatel07 alaypatel07 left review comments

@PI-Victor PI-Victor PI-Victor requested changes

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@sftim sftim Awaiting requested review from sftim

Assignees

@PI-Victor PI-Victor

@alaypatel07 alaypatel07

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
6 participants
@soltysh @k8sio-netlify-preview-bot @PI-Victor @k8s-ci-robot @tengqm @alaypatel07