Fix incorrect info about when CronJob reached GA

[sftim]

Small fixup for PR #29455
/sig apps

[netlify]

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: a532758

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61241a76e81d650008a40b61

😎 Browse the preview: https://deploy-preview-29492--kubernetes-io-main-staging.netlify.app

[kbhawkey]

Page preview:
https://deploy-preview-29492--kubernetes-io-main-staging.netlify.app/docs/concepts/workloads/controllers/cron-jobs/

[kbhawkey]

Is this change reflected in the features gates page,
https://deploy-preview-29492--kubernetes-io-main-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates

[tengqm]

According to the feature gates, CronJob v2 was GA'ed in 1.22.

[sftim]

It's true that v1.22 graduated a new CronJob controller to GA, but that's not what this feature state shortcode is about. CronJob graduated to stable in v1.21 with the new controller behind an on-by-default feature flag.

[sftim]

@kbhawkey Kubernetes APIs are themselves versioned, so a lot of them don't need a feature gate. Instead the client specifies what API they want to use via the URL they interact with. There's more to it than that, but essentially API versioning and deprecation is one thing and feature flags are another.

[kbhawkey]

@kbhawkey Kubernetes APIs are themselves versioned, so a lot of them don't need a feature gate. Instead the client specifies what API they want to use via the URL they interact with. There's more to it than that, but essentially API versioning and deprecation is one thing and feature flags are another.

Hi @sftim. OK, though I am not sure if the feature state shortcode has been used to document the version of an API? Looking at this change, I assumed that the version change corresponds to a gate change.

Also, I found this section somewhat confusing:
https://kubernetes.io/docs/concepts/workloads/controllers/cron-jobs/#new-controller

[sftim]

Another example of a feature-state shortcode being used for an API: https://kubernetes.io/docs/concepts/services-networking/ingress/

[reylejano]

CronJobs reached GA in 1.21
https://kubernetes.io/blog/2021/04/09/kubernetes-release-1.21-cronjob-ga/

the CronJobControllerV2 reached GA in 1.22
kubernetes/kubernetes#102529

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 1b6ca892d927df56b88ecb252242494335b3f1dc

[reylejano]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• content/en/OWNERS [reylejano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[benlangfeld]

@sftim The note about timezones is misleading, because it does not work with the old cronjob controller in 1.21.

[cndoit18]

@sftim The note about timezones is misleading, because it does not work with the old cronjob controller in 1.21.

ping @tengqm @sftim @reylejano 👀

[sftim]

@benlangfeld it sounds like you want to report a defect with the Kubernetes v1.21 docs about CronJob and timezones?
If that's right, I recommend you file a new issue. This PR has merged.

[benlangfeld]

@benlangfeld it sounds like you want to report a defect with the Kubernetes v1.21 docs about CronJob and timezones?
If that's right, I recommend you file a new issue. This PR has merged.

I was reporting that this PR was incorrect and shouldn't have been merged.