-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CronJobControllerV2 feature gate #30344
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing. 🔨 Explore the source changes: a55dd09 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61851d920126d0000721fae8 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 58651fa0337eecd945db65b5e5c3fa70455c6830
|
/lgtm |
@@ -255,9 +255,6 @@ different Kubernetes components. | |||
| `CSIServiceAccountToken` | `false` | Alpha | 1.20 | 1.20 | | |||
| `CSIServiceAccountToken` | `true` | Beta | 1.21 | 1.21 | | |||
| `CSIServiceAccountToken` | `true` | GA | 1.22 | | | |||
| `CronJobControllerV2` | `false` | Alpha | 1.20 | 1.20 | | |||
| `CronJobControllerV2` | `true` | Beta | 1.21 | 1.21 | | |||
| `CronJobControllerV2` | `true` | GA | 1.22 | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tengqm I did wonder about that too, but on the other hand that value is not present anymore, so you can't set it. It'll make senese for previous versions of k8s, but those have their own docs, that's why I've decided to go with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @tengqm , these are left in even though we maintain docs for the current + past 4 releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair, I'm closing the PR in that case.
6892ec8
to
a55dd09
Compare
New changes are detected. LGTM label has been removed. |
Rebased. |
@reylejano I'm going to look for a place for us to document that people reviewing release docs not remove content from the feature gate from previous releases, even if the feature no longer exists in the current release. Any suggestions where might be a good place to document that? |
@chrisnegus
|
Part of kubernetes/enhancements#19
/assign @chrisnegus @pacoxu @alaypatel07