Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid showing Analyzer results when I disable it on settings page #2633

Closed
danielbdias opened this issue Jun 1, 2023 · 0 comments · Fixed by #2642
Closed

Avoid showing Analyzer results when I disable it on settings page #2633

danielbdias opened this issue Jun 1, 2023 · 0 comments · Fixed by #2642
Assignees
@xoscar
Labels
enhancement New feature or request triage requires triage

Comments

@danielbdias
Copy link
Contributor

Describe the enhancement you'd like to see

When I disable the our Analyzer I still receive messages from it in our Trace page:

image

It could be good to remove this message or tell that it is disabled, because by showing "Trace Analyzer Result: 0" a user can think that this feature is enabled yet.
@danielbdias danielbdias added enhancement New feature or request triage requires triage labels Jun 1, 2023
@xoscar xoscar self-assigned this Jun 2, 2023
@xoscar xoscar linked a pull request Jun 2, 2023 that will close this issue
feature(frontend): Adding Analyzer empty state #2642
Merged
4 tasks
@xoscar xoscar mentioned this issue Jun 2, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xoscar xoscar

Labels
enhancement New feature or request triage requires triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature(frontend): Adding Analyzer empty state kubeshop/tracetest
2 participants
@xoscar @danielbdias