Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(frontend): switching current span during spec creation #2205

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Mar 17, 2023

This PR adds UX changes to allow users switch spans when working on a test spec or an output creation/update.

Changes

  • New change current span banner for span nodes
  • Updates assertions and selector based on selected span

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/473aa5dbe51640dea59a277d43e6fba3

@xoscar xoscar linked an issue Mar 17, 2023 that may be closed by this pull request
@schoren schoren force-pushed the main branch 3 times, most recently from 12fc235 to 02160a7 Compare March 22, 2023 00:13
@xoscar
Copy link
Contributor Author

xoscar commented Mar 22, 2023

  • Moving the call to the provider
  • Think of a way to clean up the useQuerySelector hook

@xoscar xoscar self-assigned this Mar 23, 2023
@xoscar xoscar requested review from jorgeepc, kdhamric and olha23 March 23, 2023 17:13
@xoscar xoscar marked this pull request as ready for review March 23, 2023 17:16
Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Updating selected span <LoadingOutlined />
</>
) : (
<>Select as Current span</>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<>Select as Current span</>
<>Select as current span</>

@xoscar xoscar merged commit d923c65 into main Mar 23, 2023
@xoscar xoscar deleted the 2017-switching-between-spans branch March 23, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching between spans
2 participants