feat: pluralize resource manager URLs #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoren
force-pushed
the
pluralize-resource-manager
branch
from
1d90054 to
24e575d
Compare
schoren
requested review from
jorgeepc,
danielbdias and
xoscar
and removed request for
jorgeepc
danielbdias
approved these changes
Apr 14, 2023
schoren
force-pushed
the
pluralize-resource-manager
branch
from
5a0d661 to
99cb42c
Compare
schoren
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the PAPI URLs managed by resourcemanager from singular (like
/api/pollingprofile) to plural (like/api/pollingprofiles).While this might not seem important now, it will be in the future, as we migrate resources to the RM architecture. This makes our URLs consistent.
Changes
Fixes
Checklist