feature(backend): defaulting url trigger to http if no scheme is present #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeepc
approved these changes
Apr 13, 2023
| } | ||
|
|
||
| if parsedUrl.Scheme == "" { | ||
| parsedUrl.Scheme = "http" |
There was a problem hiding this comment.
Should we have a constant for this?
There was a problem hiding this comment.
I don't think a constant is needed here. it's not a value that will be referenced any other place, it's just a default used in this only context.
danielbdias
reviewed
Apr 13, 2023
| return response, err | ||
| } | ||
|
|
||
| if parsedUrl.Scheme == "" { |
There was a problem hiding this comment.
We need to test an edge case: if the address comes with a :443, should we change this scheme to https?
There was a problem hiding this comment.
I think that's just a really weird use case, here's what postman shows
There was a problem hiding this comment.
In that case, we can live with that situation.
schoren
approved these changes
Apr 14, 2023
danielbdias
approved these changes
Apr 14, 2023
…ttp-request-trigger
xoscar
deleted the
2374-need-input-validation-on-url-field-of-http-request-trigger
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
httpscheme for URLs that doesn't have it alreadyChanges
Fixes
Checklist
https://www.loom.com/share/e435543d25e741089e5b7f70fa123228