Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix test specs snippets #2461

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Apr 28, 2023

This PR implements a new behavior for Test Specs snippets. We are introducing the following changes:

  • Add snippets to the Empty screen
  • Remove the "auto open" from the dropdown menu
  • Include a disabled state until the trace is fetched

Changes

  • Add snippets in the Empty screen,
  • Removing the auto open from the dropdown menu
  • Include a disabled state until the trace is fetched

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom

https://www.loom.com/share/5cc8c5f1a02b4af09cda1173305f18fa

@jorgeepc jorgeepc self-assigned this Apr 28, 2023
@jorgeepc jorgeepc marked this pull request as ready for review April 28, 2023 20:02
@jorgeepc jorgeepc requested a review from xoscar April 28, 2023 20:07
Copy link
Contributor

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -60,7 +59,7 @@ const AddTestSpecButton = ({selectedSpan, visibleByDefault = false}: IProps) =>
},
{type: 'divider'},
{
label: 'Empty Test Spec',
label: 'Add empty Test Spec',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep this then?

@jorgeepc jorgeepc merged commit 5c7c041 into main May 1, 2023
@jorgeepc jorgeepc deleted the 2376-fix-test-spec-snippets branch May 1, 2023 14:40
schoren pushed a commit that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Snippets Menu
2 participants