fix(pipelines): fixing environment format #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
changed the title
jorgeepc
approved these changes
May 2, 2023
Could it be because of generating them from Linux vs windows vs mac? 🤷🏾 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the environment format used for the pipelines, it also fixes an issue of having the environment id to be read-only as the generated types were not adding it to structs when marshaling it into a string
Changes
Checklist
NOTE
I found a potential problem, when using an environment as part of a test/transaction run, for the first environment creation the id can be omitted, but for the following runs the id needs to be present in order to update the existing one.
This will cause teams having to manually add the ids to their env files in case it already exists