Fix transaction run reporting #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
commented
May 30, 2023
There was a problem hiding this comment.
The changes on this file are unrelated to the PR's main objective, but they can help us in the future.
We are changing all calls to os.Exit here to a cliExit function to help us to mock os.Exit calls (which we use to debug CLI e2e tests).
danielbdias
commented
May 30, 2023
| @@ -31,7 +31,7 @@ var testRunCmd = &cobra.Command{ | |||
| environmentOptions := append(baseOptions, actions.WithClient(utils.GetResourceAPIClient("environments", cliConfig))) | |||
| environmentActions := actions.NewEnvironmentsActions(environmentOptions...) | |||
|
|
|||
| runTestAction := actions.NewRunTestAction(cliConfig, cliLogger, client, environmentActions) | |||
| runTestAction := actions.NewRunTestAction(cliConfig, cliLogger, client, environmentActions, ExitCLI) | |||
There was a problem hiding this comment.
Related with this comment: https://github.com/kubeshop/tracetest/pull/2617/files#r1209657040
schoren
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the transaction run reporting that sometimes can be shown incorrectly to the user on both FE and CLI.
Context: https://www.loom.com/share/581dbc852ef140bc9dc150977cc08c5b
Test against OTel demo: https://www.loom.com/share/58ca611ad27c47248cd4221fca5770f4
Changes
Fixes
Checklist